Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed to parse date for timezone format #1995

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

jeankhawand
Copy link
Contributor

Fix Background

on my local instance I get a bunch of error logs:

[ERROR] rss: date parser: failed to parse date "Sat, 18 Mar 2023 20:21:00 America/Los_Angeles" (entry GUID = {{ }  })
[ERROR] rss: date parser: failed to parse date "Sat, 19 Aug 2023 20:20:00 America/Los_Angeles" (entry GUID = {{ }  })
[ERROR] rss: date parser: failed to parse date "Tue, 31 Jan 2023 20:20:00 America/Los_Angeles" (entry GUID = {{ }  })
[ERROR] rss: date parser: failed to parse date "Fri, 31 Mar 2023 20:19:00 America/Los_Angeles" (entry GUID = {{ }  })
[ERROR] rss: date parser: failed to parse date "Tue, 28 Mar 2023 20:19:00 America/Los_Angeles" (entry GUID = {{ }  })
[ERROR] rss: date parser: failed to parse date "Thu, 9 Feb 2023 20:19:00 America/Los_Angeles" (entry GUID = {{ }  })
[ERROR] rss: date parser: failed to parse date "Mon, 24 Jul 2023 20:18:00 America/Los_Angeles" (entry GUID = {{ }  })
[ERROR] rss: date parser: failed to parse date "Mon, 2 Oct 2023 20:17:00 America/Los_Angeles" (entry GUID = {{ }  })
[ERROR] rss: date parser: failed to parse date "Thu, 5 Oct 2023 20:16:00 America/Los_Angeles" (entry GUID = {{ }  })
[ERROR] rss: date parser: failed to parse date "Sat, 19 Aug 2023 20:16:00 America/Los_Angeles" (entry GUID = {{ }  })

fix(date-parser): failed to parse date "Fri, 31 Mar 2023 20:19:00 America/Los_Angeles" by adding timezone to invalidTimezoneReplacer
test(date-parser): add TestParseRSSDateTimezone unit test

Do you follow the guidelines?

…rica/Los_Angeles" by adding timezone to invalidTimezoneReplacer

test(date-parser): add TestParseRSSDateTimezone unit test
@fguillot fguillot merged commit da0198c into miniflux:main Aug 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants