Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Odysee video duration as read time #1761

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Use Odysee video duration as read time #1761

merged 1 commit into from
Aug 10, 2023

Conversation

kmein
Copy link
Contributor

@kmein kmein commented Mar 21, 2023

I really enjoy the YouTube watch-time feature.
However, I also enjoy watching videos on Odysee.
I implemented an analogue for the YouTube watch-time feature for Odysee.
These are my first lines in Go, so they might not be perfectly idiomatic.

This feature works by scraping the Odysee website.

To enable it, set the FETCH_ODYSEE_WATCH_TIME environment variable to 1.

Do you follow the guidelines?

@kmein kmein marked this pull request as ready for review March 21, 2023 18:52
@fguillot
Copy link
Member

Do you mind sharing an example of feed to test this feature?

@kmein
Copy link
Contributor Author

kmein commented Mar 26, 2023

@fguillot
Copy link
Member

@fguillot https://odysee.com/$/rss/@BrodieRobertson:5

I'm not able to make it work. The reading time still shows 1 minute everywhere.

@kmein kmein force-pushed the main branch 2 times, most recently from 5504141 to ed00525 Compare August 1, 2023 20:20
@kmein
Copy link
Contributor Author

kmein commented Aug 1, 2023

I have made it work. @fguillot: I would be happy if you could test it again.

reader/processor/processor.go Fixed Show resolved Hide resolved
@kmein kmein force-pushed the main branch 2 times, most recently from ab8d18e to 5d35b63 Compare August 3, 2023 06:43
@kmein kmein requested a review from fguillot August 7, 2023 06:30
This feature works by scraping the Odysee website.

To enable it, set the FETCH_ODYSEE_WATCH_TIME environment variable to
1.
@fguillot fguillot merged commit 3060946 into miniflux:main Aug 10, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants