Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not override .hostname() or .domain() from builder with parsed URI #263

Closed
wants to merge 1 commit into from
Closed

Conversation

brandonros
Copy link

painstakingly addresses #257

@minghuaw minghuaw added the breaking This would need a breaking release label Aug 4, 2024
@minghuaw
Copy link
Owner

minghuaw commented Aug 4, 2024

I think the docs will need to be updated to reflect this change as well

@brandonros
Copy link
Author

I think the docs will need to be updated to reflect this change as well

can you help me understand how your vision? for example:

    let connection = Connection::builder()
        .container_id(container_id)
        .domain(relay_domain) // extra -relay
        .hostname(relay_domain) // extra -relay
        .tls_connector(tls_connector)
        .alt_tls_establishment(true)
        //.open_with_stream(ws_stream)
        .open(connection_string.as_str())
        .await
        .unwrap();

.open(connection_string is its own host

in order to do an override, i would've thought .hostname overrides the host for the container

i'm down for a .host() non-breaking (or we can just close this), i just know this is something rhea suppots

https://github.com/search?q=repo%3Aamqp%2Frhea%20host&type=code

@brandonros
Copy link
Author

@minghuaw
Copy link
Owner

minghuaw commented Aug 7, 2024

Closing in favor of #276

@minghuaw minghuaw closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This would need a breaking release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants