Skip to content

Commit

Permalink
Merge pull request #12 from mineiros-io/mariux/allow-empty-members-in…
Browse files Browse the repository at this point in the history
…-policy-bindings

feat: allow empty members in policy bindings
  • Loading branch information
mariux authored Dec 29, 2021
2 parents afff354 + a2611ee commit e8f5acc
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 11 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.1.3]

### Added

- Support empty members list in policy_bindings

## [0.1.2]

### Fixed
Expand All @@ -27,7 +33,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

<!-- markdown-link-check-disable -->

[unreleased]: https://github.com/mineiros-io/terraform-google-secret-manager/compare/v0.1.1...HEAD
[unreleased]: https://github.com/mineiros-io/terraform-google-secret-manager/compare/v0.1.3...HEAD
[0.1.3]: https://github.com/mineiros-io/terraform-google-secret-manager/compare/v0.1.2...v0.1.3
[0.1.2]: https://github.com/mineiros-io/terraform-google-secret-manager/compare/v0.1.1...v0.1.2
[0.1.1]: https://github.com/mineiros-io/terraform-google-secret-manager/compare/v0.1.0...v0.1.1
[0.1.0]: https://github.com/mineiros-io/terraform-google-secret-manager/releases/tag/v0.1.0
Expand Down
18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Most basic usage just setting required arguments:

```hcl
module "terraform-google-secret-manager" {
source = "github.com/mineiros-io/terraform-google-secret-manager.git?ref=v0.1.0"
source = "github.com/mineiros-io/terraform-google-secret-manager.git?ref=v0.1.3"
secret_id = "secret"
}
Expand All @@ -65,7 +65,7 @@ See [variables.tf] and [examples/] for details and use-cases.
- **`module_enabled`**: _(Optional `bool`)_

Specifies whether resources in the module will be created.

Default is `true`.

- **`module_depends_on`**: _(Optional `list(dependencies)`)_
Expand Down Expand Up @@ -106,7 +106,7 @@ See [variables.tf] and [examples/] for details and use-cases.
- **`customer_managed_encryption`**: _(Optional `object(customer_managed_encryption)`)_

Customer Managed Encryption for the secret.

Example

```hcl
Expand All @@ -123,12 +123,12 @@ See [variables.tf] and [examples/] for details and use-cases.
- **`labels`**: _(Optional `map(string)`)_
The labels assigned to this Secret. Label keys must be between 1 and 63 characters long, have a UTF-8 encoding of maximum 128 bytes, and must conform to the following PCRE regular expression: `[\p{Ll}\p{Lo}][\p{Ll}\p{Lo}\p{N}-]{0,62}` Label values must be between 0 and 63 characters long, have a UTF-8 encoding of maximum 128 bytes, and must conform to the following PCRE regular expression: `[\p{Ll}\p{Lo}\p{N}-]{0,63}` No more than 64 labels can be assigned to a given resource. An object containing a list of `key: value` pairs.
The labels assigned to this Secret. Label keys must be between 1 and 63 characters long, have a UTF-8 encoding of maximum 128 bytes, and must conform to the following PCRE regular expression: `[\p{Ll}\p{Lo}][\p{Ll}\p{Lo}\p{N}-]{0,62}` Label values must be between 0 and 63 characters long, have a UTF-8 encoding of maximum 128 bytes, and must conform to the following PCRE regular expression: `[\p{Ll}\p{Lo}\p{N}-]{0,63}` No more than 64 labels can be assigned to a given resource. An object containing a list of `key: value` pairs.
Example
```hcl
```hcl
labels = {
"app": "web",
"app": "web",
"env": "prod"
}
```
Expand All @@ -150,7 +150,7 @@ See [variables.tf] and [examples/] for details and use-cases.
The rotation time and period for a Secret. At `next_rotation_time`, Secret Manager will send a Pub/Sub notification to the topics configured on the Secret. `topics` must be set to configure rotation.

Example

```hcl
rotation = {
next_rotation_time = "2022-10-02T15:01:23.045123456Z"
Expand Down Expand Up @@ -389,4 +389,4 @@ Copyright &copy; 2020-2021 [Mineiros GmbH][homepage]
[pull requests]: https://github.com/mineiros-io/terraform-google-secret-manager/pulls
[contribution guidelines]: https://github.com/mineiros-io/terraform-google-secret-manager/blob/main/CONTRIBUTING.md
<!-- markdown-link-check-enable -->
<!-- markdown-link-check-enable -->
2 changes: 1 addition & 1 deletion iam.tf
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ locals {
}

module "iam" {
source = "github.com/mineiros-io/terraform-google-secret-manager-iam?ref=v0.0.3"
source = "github.com/mineiros-io/terraform-google-secret-manager-iam?ref=v0.0.4"

for_each = var.policy_bindings != null ? local.policy_bindings : local.iam_map

Expand Down

0 comments on commit e8f5acc

Please sign in to comment.