Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre commit hooks #187

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

sebastianMindee
Copy link
Collaborator

Description

  • ⬆️ add pre-commit & auto-lint fix to CI.
  • 🐛 fix incorrect indent rule for eslint

Related Issue

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

.lintstagedrc.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@ianardee ianardee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem to work in GH

 1 package is looking for funding
  run `npm fund` for details
npm ERR! code 1
npm ERR! path /home/runner/work/mindee-api-nodejs/mindee-api-nodejs/dist
npm ERR! command failed
npm ERR! command sh -c husky install
npm ERR! husky - .git can't be found (see https://typicode.github.io/husky/#/?id=custom-directory)

npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/2023-08-11T11_02_48_864Z-debug-0.log
Error: Process completed with exit code 1.

@sebastianMindee sebastianMindee merged commit 3236f26 into develop/v4 Aug 11, 2023
8 checks passed
@sebastianMindee sebastianMindee deleted the update-pre-commit-hooks branch August 11, 2023 14:58
sebastianMindee added a commit that referenced this pull request Aug 11, 2023
ianardee pushed a commit that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants