Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix endless timeout on CI test #68

Merged
merged 1 commit into from
Mar 13, 2024
Merged

🐛 fix endless timeout on CI test #68

merged 1 commit into from
Mar 13, 2024

Conversation

sebastianMindee
Copy link
Contributor

@sebastianMindee sebastianMindee commented Mar 12, 2024 •
edited
Loading

Description

Tweaked error returns for async calls so that invalid calls don't block the CI.

Related Issue

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@sebastianMindee sebastianMindee marked this pull request as ready for review March 12, 2024 15:50
@sebastianMindee sebastianMindee merged commit 2e6494a into main Mar 13, 2024
1 check passed
@sebastianMindee sebastianMindee deleted the fix-generated-test branch March 13, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianardee ianardee ianardee approved these changes

@xaviermindee xaviermindee Awaiting requested review from xaviermindee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianMindee @ianardee