Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return array data type in infer_dtype_bydata #2144

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

return array data type in infer_dtype_bydata #2144

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
40cde1d
return array data type in infer_dtype_bydata
Jun 20, 2024
87ae1c3
return array data type in infer_dtype_bydata
Jun 20, 2024
85f7797
return array data type in infer_dtype_bydata
Jun 20, 2024
debb42f
add array data type for milvus vector store collection create
Jun 27, 2024
76c0593
add array data type for milvus vector store collection create
Jun 27, 2024
8521df5
add array data type for milvus vector store collection create
Jun 27, 2024
fea309d
reformatted
Jul 4, 2024
27e3c7e
reformatted
Jul 5, 2024
b779ad2
reformatted
Jul 5, 2024
871486c
reformatted
Jul 5, 2024
cadea3f
reformatted,
Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions pymilvus/orm/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ def is_numeric_datatype(data_type: DataType):
return is_float_datatype(data_type) or is_integer_datatype(data_type)


def is_varchar_datatype(data_type: DataType):
return data_type in (DataType.VARCHAR,)


def is_bool_datatype(data_type: DataType):
return data_type in (DataType.BOOL,)


# pylint: disable=too-many-return-statements
def infer_dtype_by_scalar_data(data: Any):
if isinstance(data, float):
Expand Down Expand Up @@ -105,7 +113,7 @@ def infer_dtype_by_scalar_data(data: Any):
return DataType.UNKNOWN


def infer_dtype_bydata(data: Any):
def infer_dtype_bydata(data: Any, **kwargs):
d_type = DataType.UNKNOWN
if is_scalar(data):
return infer_dtype_by_scalar_data(data)
Expand All @@ -121,7 +129,16 @@ def infer_dtype_bydata(data: Any):
failed = True
if not failed:
d_type = dtype_str_map.get(type_str, DataType.UNKNOWN)
return DataType.FLOAT_VECTOR if is_numeric_datatype(d_type) else DataType.UNKNOWN
if is_varchar_datatype(d_type) or is_bool_datatype(d_type):
return DataType.ARRAY
if (
kwargs is None
or len(kwargs) == 0
or (kwargs["type"] is not None and kwargs["type"] == "vector")
):
return DataType.FLOAT_VECTOR if is_numeric_datatype(d_type) else DataType.UNKNOWN
else:
return DataType.ARRAY

if d_type == DataType.UNKNOWN:
try:
Expand Down