Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] rbac custom group privilege level check #39194

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

shaoting-huang
Copy link
Contributor

cherry-pick from master: #39164
related: related: #39086

Signed-off-by: shaoting-huang <[email protected]>
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. labels Jan 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 13, 2025
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 89.36170% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (af22644) to head (c330f36).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 88.37% 4 Missing and 1 partial ⚠️
pkg/util/paramtable/rbac_param.go 91.42% 2 Missing and 1 partial ⚠️
internal/rootcoord/meta_table.go 0.00% 1 Missing ⚠️
pkg/util/constant.go 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39194      +/-   ##
==========================================
- Coverage   80.44%   79.50%   -0.94%     
==========================================
  Files        1077     1077              
  Lines      169731   169767      +36     
==========================================
- Hits       136534   134979    -1555     
- Misses      28713    30287    +1574     
- Partials     4484     4501      +17     
Files with missing lines Coverage Δ
internal/proxy/impl.go 83.86% <ø> (-0.01%) ⬇️
internal/proxy/util.go 90.47% <ø> (-0.21%) ⬇️
internal/rootcoord/meta_table.go 83.97% <0.00%> (ø)
pkg/util/constant.go 96.15% <93.33%> (-0.68%) ⬇️
pkg/util/paramtable/rbac_param.go 97.14% <91.42%> (-2.09%) ⬇️
internal/rootcoord/root_coord.go 87.90% <88.37%> (-0.03%) ⬇️

... and 95 files with indirect coverage changes

@sre-ci-robot sre-ci-robot merged commit e563997 into milvus-io:2.4 Jan 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants