Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [Cherry-pick] report auth log to hook when grpc authenticate failed #39192

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Jan 13, 2025

relate: #38943

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 13, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

@aoiasd Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (ac730be) to head (fac2a45).
Report is 11 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39192      +/-   ##
==========================================
- Coverage   81.10%   81.08%   -0.02%     
==========================================
  Files        1389     1389              
  Lines      196366   196366              
==========================================
- Hits       159254   159232      -22     
- Misses      31532    31537       +5     
- Partials     5580     5597      +17     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.54% <ø> (ø)
Go 83.05% <100.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/distributed/proxy/service.go 85.35% <100.00%> (ø)

... and 35 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 13, 2025

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 13, 2025
@SimFG
Copy link
Contributor

SimFG commented Jan 14, 2025

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e6ac2fe into milvus-io:2.5 Jan 14, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants