Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5]intermin index support different index type and more metric type(fp16/bf16) #39180

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

cqy123456
Copy link
Contributor

No description provided.

@cqy123456 cqy123456 changed the title enhance: intermin index support index without raw data and metric type fp16/bf16 enhance: [2.5]intermin index support index without raw data and metric type fp16/bf16 Jan 12, 2025
@sre-ci-robot sre-ci-robot added area/compilation size/XL Denotes a PR that changes 500-999 lines. labels Jan 12, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cqy123456
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Jan 12, 2025
Copy link
Contributor

mergify bot commented Jan 12, 2025

@cqy123456 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Jan 12, 2025
Copy link
Contributor

mergify bot commented Jan 12, 2025

@cqy123456 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Jan 12, 2025

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 50.19608% with 127 lines in your changes missing coverage. Please review.

Project coverage is 69.37%. Comparing base (39fa00f) to head (189ec69).
Report is 3 commits behind head on 2.5.

Current head 189ec69 differs from pull request most recent head 476fb9c

Please upload reports for the commit 476fb9c to get more accurate results.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 4.08% 47 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 45.16% 34 Missing ⚠️
internal/core/src/segcore/FieldIndexing.cpp 69.33% 23 Missing ⚠️
internal/core/src/segcore/segcore_init_c.cpp 7.69% 12 Missing ⚠️
internal/core/src/index/VectorMemIndex.cpp 72.72% 3 Missing ⚠️
internal/core/src/segcore/SegcoreConfig.h 50.00% 3 Missing ⚠️
internal/core/src/segcore/FieldIndexing.h 85.71% 2 Missing ⚠️
internal/core/src/segcore/SegmentGrowingImpl.cpp 80.00% 2 Missing ⚠️
internal/core/src/segcore/IndexConfigGenerator.cpp 80.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (39fa00f) and HEAD (189ec69). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (39fa00f) HEAD (189ec69)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39180       +/-   ##
===========================================
- Coverage   81.04%   69.37%   -11.67%     
===========================================
  Files        1389      294     -1095     
  Lines      196360    26629   -169731     
===========================================
- Hits       159142    18475   -140667     
+ Misses      31606     8154    -23452     
+ Partials     5612        0     -5612     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.37% <50.19%> (-0.18%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/exec/expression/UnaryExpr.cpp 84.51% <100.00%> (ø)
internal/core/src/index/VectorMemIndex.h 100.00% <ø> (ø)
internal/core/src/segcore/ConcurrentVector.h 96.02% <100.00%> (+0.19%) ⬆️
internal/core/src/segcore/SegmentGrowingImpl.h 69.41% <100.00%> (+0.36%) ⬆️
internal/core/src/segcore/vector_index_c.cpp 22.22% <ø> (ø)
internal/core/src/segcore/IndexConfigGenerator.cpp 82.75% <80.00%> (-0.27%) ⬇️
internal/core/src/segcore/FieldIndexing.h 69.56% <85.71%> (+2.25%) ⬆️
internal/core/src/segcore/SegmentGrowingImpl.cpp 82.50% <80.00%> (-0.30%) ⬇️
internal/core/src/index/VectorMemIndex.cpp 65.07% <72.72%> (+0.27%) ⬆️
internal/core/src/segcore/SegcoreConfig.h 81.25% <50.00%> (-18.75%) ⬇️
... and 4 more

... and 1095 files with indirect coverage changes

@cqy123456 cqy123456 changed the title enhance: [2.5]intermin index support index without raw data and metric type fp16/bf16 enhance: [2.5]intermin index support different index type and more metric type(fp16/bf16) Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 13, 2025

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 13, 2025

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 13, 2025

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 13, 2025

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 13, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation dco-passed DCO check passed. do-not-merge/missing-related-issue do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants