Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail to get empty index num rows #39155

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

smellthemoon
Copy link
Contributor

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (826b726) to head (9a8a734).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/index/ScalarIndexSort.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39155      +/-   ##
==========================================
- Coverage   81.16%   81.14%   -0.02%     
==========================================
  Files        1395     1395              
  Lines      197277   197279       +2     
==========================================
- Hits       160124   160089      -35     
- Misses      31539    31575      +36     
- Partials     5614     5615       +1     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.64% <75.00%> (-0.01%) ⬇️
Go 83.08% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/index/ScalarIndexSort.cpp 70.00% <75.00%> (-0.20%) ⬇️

... and 26 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 10, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 13, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit accc9e7 into milvus-io:master Jan 13, 2025
18 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jan 14, 2025
gifi-siby pushed a commit to gifi-siby/milvus that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants