Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add trigger interval config for auto balance #39154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Jan 10, 2025

issue: #39156

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 10, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.14%. Comparing base (2a02bbe) to head (a9e1a0f).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39154      +/-   ##
==========================================
+ Coverage   81.11%   81.14%   +0.02%     
==========================================
  Files        1395     1395              
  Lines      197434   197459      +25     
==========================================
+ Hits       160154   160223      +69     
+ Misses      31641    31604      -37     
+ Partials     5639     5632       -7     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.68% <ø> (+<0.01%) ⬆️
Go 83.07% <95.16%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
internal/querycoordv2/checkers/balance_checker.go 98.34% <100.00%> (+2.08%) ⬆️
pkg/util/paramtable/component_param.go 98.39% <100.00%> (+<0.01%) ⬆️

... and 27 files with indirect coverage changes

@weiliu1031 weiliu1031 force-pushed the add_stopping_balance_interval branch from a652cd9 to a9e1a0f Compare January 13, 2025 03:17
Copy link
Contributor

mergify bot commented Jan 13, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants