Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data race when accessing field_ when retrieving #39152

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 10, 2025

issue: #39148
pr: #39151

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 10, 2025

rerun go-sdk

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (6b127d4) to head (a72cc70).
Report is 5 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39152       +/-   ##
===========================================
+ Coverage   69.54%   81.09%   +11.54%     
===========================================
  Files         294     1389     +1095     
  Lines       26462   196355   +169893     
===========================================
+ Hits        18403   159230   +140827     
- Misses       8059    31536    +23477     
- Partials        0     5589     +5589     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.53% <0.00%> (-0.01%) ⬇️
Go 83.06% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.cpp 83.86% <0.00%> (-0.25%) ⬇️

... and 1095 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 10, 2025
@chyezh
Copy link
Contributor Author

chyezh commented Jan 10, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 10, 2025

rerun go-sdk

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 0aa592b into milvus-io:2.5 Jan 13, 2025
17 of 20 checks passed
@chyezh chyezh deleted the fix_data_race_for_field_access_2_5 branch January 13, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants