-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.5] fix chunk cache madvise when sparse raw data is mmaped #39146
Conversation
Signed-off-by: Buqian Zheng <[email protected]>
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@zhengbuqian Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@zhengbuqian E2e jenkins job failed, comment |
/run-cpu-e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #39146 +/- ##
===========================================
- Coverage 81.02% 69.55% -11.48%
===========================================
Files 1389 294 -1095
Lines 196343 26460 -169883
===========================================
- Hits 159091 18403 -140688
+ Misses 31629 8057 -23572
+ Partials 5623 0 -5623
|
issue: #39158 |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
instead of marking as not supported, ChunkedSparseFloatColumn::DataByteSize can simply use the impl of super class.
pr: #39145
issue: #39158