Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] fix chunk cache madvise when sparse raw data is mmaped #39146

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

zhengbuqian
Copy link
Collaborator

@zhengbuqian zhengbuqian commented Jan 10, 2025

instead of marking as not supported, ChunkedSparseFloatColumn::DataByteSize can simply use the impl of super class.
pr: #39145
issue: #39158

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@zhengbuqian

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@zhengbuqian zhengbuqian changed the title fix[2.5]: fix chunk cache madvise when sparse raw data is mmaped fix: [2.5] fix chunk cache madvise when sparse raw data is mmaped Jan 10, 2025
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@zhengbuqian Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Jan 10, 2025

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.55%. Comparing base (95809ca) to head (1d7317f).
Report is 3 commits behind head on 2.5.

❗ There is a different number of reports uploaded between BASE (95809ca) and HEAD (1d7317f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (95809ca) HEAD (1d7317f)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39146       +/-   ##
===========================================
- Coverage   81.02%   69.55%   -11.48%     
===========================================
  Files        1389      294     -1095     
  Lines      196343    26460   -169883     
===========================================
- Hits       159091    18403   -140688     
+ Misses      31629     8057    -23572     
+ Partials     5623        0     -5623     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.55% <ø> (+<0.01%) ⬆️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/mmap/ChunkedColumn.h 53.54% <ø> (+0.83%) ⬆️

... and 1095 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 10, 2025
@zhengbuqian
Copy link
Collaborator Author

issue: #39158

@sunby
Copy link
Contributor

sunby commented Jan 10, 2025

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Jan 10, 2025
@sre-ci-robot sre-ci-robot merged commit a43720f into milvus-io:2.5 Jan 10, 2025
16 of 20 checks passed
@zhengbuqian zhengbuqian deleted the chunked-sparse-2.5 branch January 10, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants