Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use template to remove unittest duplication #39144

Merged

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Jan 10, 2025

Issue: #38666

@cydrain cydrain changed the title enhance: Use template to remove unittest duplication [skip e2e] enhance: Use template to remove unittest duplication Jan 10, 2025
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@cydrain

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@cydrain cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (86d665a) to head (dbf114c).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39144       +/-   ##
===========================================
- Coverage   81.13%   69.67%   -11.47%     
===========================================
  Files        1395      296     -1099     
  Lines      197359    26633   -170726     
===========================================
- Hits       160131    18556   -141575     
+ Misses      31599     8077    -23522     
+ Partials     5629        0     -5629     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.67% <ø> (+0.03%) ⬆️
Go ∅ <ø> (∅)

see 1100 files with indirect coverage changes

@cydrain cydrain force-pushed the caiyd_38666_template_data_type_test branch from 4b48f2b to d7cbe8c Compare January 10, 2025 06:23
@cydrain
Copy link
Contributor Author

cydrain commented Jan 10, 2025

rerun cpp-unit-test

@zhengbuqian
Copy link
Collaborator

/lgtm

Copy link
Contributor

mergify bot commented Jan 10, 2025

@cydrain cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@cydrain cydrain force-pushed the caiyd_38666_template_data_type_test branch from d7cbe8c to 66ec140 Compare January 10, 2025 09:38
@sre-ci-robot sre-ci-robot removed the lgtm label Jan 10, 2025
@cydrain cydrain changed the title [skip e2e] enhance: Use template to remove unittest duplication enhance: Use template to remove unittest duplication Jan 10, 2025
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Jan 10, 2025
@cydrain cydrain changed the title enhance: Use template to remove unittest duplication [skip e2e] enhance: Use template to remove unittest duplication Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@cydrain

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@cydrain cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 10, 2025
@cydrain cydrain changed the title [skip e2e] enhance: Use template to remove unittest duplication enhance: Use template to remove unittest duplication Jan 10, 2025
@mergify mergify bot removed the ci-passed label Jan 10, 2025
@cydrain cydrain force-pushed the caiyd_38666_template_data_type_test branch from 66ec140 to dbf114c Compare January 10, 2025 15:39
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 13, 2025
@yanliang567
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alwayslove2013
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 2a02bbe into milvus-io:master Jan 13, 2025
18 of 19 checks passed
@cydrain cydrain deleted the caiyd_38666_template_data_type_test branch January 13, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants