Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: simplify compaction tasks to reduce their memory overhead #39121

Merged

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Jan 9, 2025

See #39080

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby January 9, 2025 11:46
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Jan 9, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.16%. Comparing base (fd84ed8) to head (c67ba78).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/compaction_task_mix.go 76.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39121       +/-   ##
===========================================
+ Coverage   69.71%   81.16%   +11.44%     
===========================================
  Files         299     1404     +1105     
  Lines       26768   197668   +170900     
===========================================
+ Hits        18661   160434   +141773     
- Misses       8107    31614    +23507     
- Partials        0     5620     +5620     
Components Coverage Δ
Client 79.53% <ø> (∅)
Core 69.71% <ø> (ø)
Go 83.09% <83.33%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 71.27% <ø> (ø)
internal/datacoord/compaction_task.go 100.00% <ø> (ø)
internal/datacoord/compaction_task_clustering.go 79.89% <100.00%> (ø)
internal/datacoord/compaction_task_l0.go 92.30% <100.00%> (ø)
internal/datacoord/compaction_task_mix.go 66.93% <76.47%> (ø)

... and 1100 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 9, 2025
internal/datacoord/compaction.go Outdated Show resolved Hide resolved
internal/datacoord/compaction.go Outdated Show resolved Hide resolved
internal/datacoord/compaction_test.go Outdated Show resolved Hide resolved
internal/datacoord/compaction_test.go Outdated Show resolved Hide resolved
@mergify mergify bot removed the ci-passed label Jan 10, 2025
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot added the ci-passed label Jan 10, 2025
@tedxu tedxu force-pushed the enhance/simplify_compaction_tasks branch from 2855658 to fd38263 Compare January 10, 2025 06:05
@sre-ci-robot sre-ci-robot removed the lgtm label Jan 10, 2025
@mergify mergify bot removed the ci-passed label Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu tedxu force-pushed the enhance/simplify_compaction_tasks branch from fd38263 to c67ba78 Compare January 14, 2025 08:34
@mergify mergify bot added the ci-passed label Jan 15, 2025
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e501025 into milvus-io:master Jan 15, 2025
20 checks passed
@tedxu tedxu deleted the enhance/simplify_compaction_tasks branch January 15, 2025 07:04
gifi-siby pushed a commit to gifi-siby/milvus that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants