-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: simplify compaction tasks to reduce their memory overhead #39121
enhance: simplify compaction tasks to reduce their memory overhead #39121
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39121 +/- ##
===========================================
+ Coverage 69.71% 81.16% +11.44%
===========================================
Files 299 1404 +1105
Lines 26768 197668 +170900
===========================================
+ Hits 18661 160434 +141773
- Misses 8107 31614 +23507
- Partials 0 5620 +5620
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
2855658
to
fd38263
Compare
@tedxu E2e jenkins job failed, comment |
Signed-off-by: Ted Xu <[email protected]>
Signed-off-by: Ted Xu <[email protected]>
fd38263
to
c67ba78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tedxu, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ilvus-io#39121) See milvus-io#39080 --------- Signed-off-by: Ted Xu <[email protected]>
See #39080