Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add broadcast operation for msgstream #39119

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 9, 2025

issue: #38399
pr: #39040

  • make broadcast service available for msgstream by reusing the architecture streaming service

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jan 9, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 9, 2025
Copy link
Contributor

mergify bot commented Jan 9, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 59.79899% with 80 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (b0afe32) to head (d49bfa5).
Report is 13 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/rootcoord/broadcast_task.go 8.77% 52 Missing ⚠️
...treaming/util/message/adaptor/broadcast_message.go 0.00% 12 Missing ⚠️
pkg/streaming/util/types/responses.go 86.04% 6 Missing ⚠️
internal/distributed/streaming/util.go 55.55% 4 Missing ⚠️
internal/rootcoord/dml_channels.go 0.00% 3 Missing ⚠️
...eamingcoord/server/broadcaster/broadcaster_impl.go 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39119      +/-   ##
==========================================
- Coverage   81.07%   81.03%   -0.05%     
==========================================
  Files        1389     1394       +5     
  Lines      196349   196479     +130     
==========================================
+ Hits       159191   159211      +20     
- Misses      31556    31657     +101     
- Partials     5602     5611       +9     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.55% <ø> (ø)
Go 82.98% <59.59%> (-0.06%) ⬇️
Files with missing lines Coverage Δ
internal/distributed/streaming/streaming.go 100.00% <100.00%> (ø)
internal/distributed/streaming/wal.go 65.48% <100.00%> (+1.26%) ⬆️
internal/rootcoord/root_coord.go 88.24% <100.00%> (+0.01%) ⬆️
internal/streamingcoord/client/client.go 97.01% <100.00%> (+0.18%) ⬆️
internal/streamingcoord/client/client_impl.go 80.00% <100.00%> (+5.00%) ⬆️
...ord/server/broadcaster/registry/append_operator.go 100.00% <100.00%> (ø)
...gcoord/server/broadcaster/registry/test_utility.go 100.00% <100.00%> (ø)
internal/streamingcoord/server/broadcaster/task.go 100.00% <100.00%> (ø)
internal/streamingcoord/server/server.go 71.69% <100.00%> (ø)
internal/util/streamingutil/util/wal_selector.go 100.00% <100.00%> (+5.71%) ⬆️
... and 9 more

... and 23 files with indirect coverage changes

@chyezh chyezh force-pushed the enhance_add_broadcast_for_msgstream_2_5 branch from 487c56f to 98b75d7 Compare January 10, 2025 06:08
@chyezh chyezh changed the title enhance: move streaming coord from datacoord to rootcoord enhance: add broadcast operation for msgstream Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_add_broadcast_for_msgstream_2_5 branch from 98b75d7 to 9d6aef0 Compare January 10, 2025 07:18
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_add_broadcast_for_msgstream_2_5 branch from 9d6aef0 to e6e4162 Compare January 10, 2025 09:18
@chyezh chyezh force-pushed the enhance_add_broadcast_for_msgstream_2_5 branch from e6e4162 to 6b1f7d4 Compare January 10, 2025 09:51
- make broadcast service available for msgstream by reusing the architecture streaming service

Signed-off-by: chyezh <[email protected]>
Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the enhance_add_broadcast_for_msgstream_2_5 branch from 6b1f7d4 to d49bfa5 Compare January 10, 2025 11:57
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 10, 2025

rerun go-sdk

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 54036bc into milvus-io:2.5 Jan 14, 2025
18 of 20 checks passed
@chyezh chyezh deleted the enhance_add_broadcast_for_msgstream_2_5 branch January 14, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants