enhance: Add schema update time verification for insert and upsert to use cache #39096

JsDove · 2025-01-08T12:59:10Z

enhance: Add schema update time verification for insert and upsert to use cache
issue: #39093

mergify · 2025-01-08T14:13:37Z

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov · 2025-01-08T15:05:04Z

Codecov Report

Attention: Patch coverage is 67.16418% with 22 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (a99c92e) to head (a8d5aca).
Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/proxy/task_insert.go	50.00%	6 Missing and 2 partials ⚠️
internal/proxy/task_upsert.go	50.00%	6 Missing and 2 partials ⚠️
internal/rootcoord/alter_collection_task.go	50.00%	4 Missing ⚠️
pkg/util/merr/utils.go	75.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #39096       +/-   ##
===========================================
+ Coverage   69.48%   81.01%   +11.53%     
===========================================
  Files         300     1408     +1108     
  Lines       26905   198624   +171719     
===========================================
+ Hits        18694   160909   +142215     
- Misses       8211    32056    +23845     
- Partials        0     5659     +5659

Components	Coverage Δ
Client	`79.50% <ø> (∅)`
Core	`69.48% <ø> (-0.01%)`	⬇️
Go	`82.95% <67.16%> (∅)`

Files with missing lines	Coverage Δ
internal/metastore/model/collection.go	`84.51% <100.00%> (ø)`
internal/proxy/impl.go	`83.85% <100.00%> (ø)`
internal/proxy/meta_cache.go	`90.66% <100.00%> (ø)`
internal/proxy/task.go	`80.65% <100.00%> (ø)`
internal/rootcoord/create_collection_task.go	`90.47% <100.00%> (ø)`
internal/rootcoord/root_coord.go	`89.90% <100.00%> (ø)`
pkg/util/merr/errors.go	`92.18% <ø> (ø)`
pkg/util/merr/utils.go	`84.19% <75.00%> (ø)`
internal/rootcoord/alter_collection_task.go	`53.30% <50.00%> (ø)`
internal/proxy/task_insert.go	`72.99% <50.00%> (ø)`
... and 1 more

... and 1098 files with indirect coverage changes

mergify · 2025-01-09T07:00:32Z

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2025-01-09T12:08:43Z

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2025-01-09T12:25:30Z

@JsDove cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

JsDove · 2025-01-09T12:38:29Z

rerun cpp-unit-test

JsDove · 2025-01-09T12:38:41Z

/run-cpu-e2e

liliu-z

/lgtm
/approve

mergify · 2025-01-17T09:57:44Z

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

JsDove · 2025-01-17T10:01:14Z

/run-cpu-e2e

sre-ci-robot · 2025-01-17T10:37:36Z

New changes are detected. LGTM label has been removed.

mergify · 2025-01-17T10:38:38Z

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2025-01-17T10:39:07Z

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

xiaofan-luan · 2025-01-19T14:15:39Z

internal/proxy/task_insert.go

+	if it.schemaTimestamp != 0 {
+		if it.schemaTimestamp != colInfo.updateTimestamp {
+			err := merr.WrapErrCollectionSchemaMisMatch(collectionName)
+			log.Ctx(ctx).Warn("collection schema mismatch", zap.String("collectionName", collectionName), zap.Error(err))


don't need a warn log here.
An info should be good because this error is as expected

xiaofan-luan · 2025-01-19T14:19:26Z

/approve

sre-ci-robot · 2025-01-19T14:19:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JsDove, liliu-z, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [liliu-z,xiaofan-luan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… the cache Signed-off-by: Xianhui.Lin <[email protected]> fix unitest Signed-off-by: Xianhui.Lin <[email protected]> improve Signed-off-by: Xianhui.Lin <[email protected]> improve Signed-off-by: Xianhui.Lin <[email protected]> fix code Signed-off-by: Xianhui.Lin <[email protected]> fix test Signed-off-by: Xianhui.Lin <[email protected]> fix go test Signed-off-by: Xianhui.Lin <[email protected]> add go unitest Signed-off-by: Xianhui.Lin <[email protected]> fix unitest error Signed-off-by: Xianhui.Lin <[email protected]> fix ut Signed-off-by: Xianhui.Lin <[email protected]> improve Signed-off-by: Xianhui.Lin <[email protected]> createcollection use creats Signed-off-by: Xianhui.Lin <[email protected]> save to etcd Signed-off-by: Xianhui.Lin <[email protected]> fix e2e test error Signed-off-by: Xianhui.Lin <[email protected]> modify log level Signed-off-by: Xianhui.Lin <[email protected]>

mergify · 2025-01-20T03:08:42Z

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

JsDove · 2025-01-20T09:00:27Z

/run-cpu-e2e

mergify · 2025-01-20T10:06:58Z

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

JsDove · 2025-01-20T11:11:45Z

/run-cpu-e2e

…rt to use cache (#39382) enhance: Add schema update time verification for insert and upsert to use cache issue: #39093 Related to pr: #39096 --------- Signed-off-by: Xianhui.Lin <[email protected]>

…rt to use cache (#39405) enhance: Add schema update time verification for insert and upsert to use cache issue: #39093 Related to pr: #39096 Signed-off-by: Xianhui.Lin <[email protected]>

sre-ci-robot added area/dependency Pull requests that update a dependency file size/M Denotes a PR that changes 30-99 lines. labels Jan 8, 2025

sre-ci-robot requested review from congqixia, cydrain and czs007 January 8, 2025 12:59

JsDove mentioned this pull request Jan 8, 2025

[Enhancement]: Add schema update time verification for insert and upsert to use cache #39093

Open

1 task

mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 8, 2025

JsDove force-pushed the schemacache branch 2 times, most recently from e9ddceb to 3185bf6 Compare January 9, 2025 02:30

sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jan 9, 2025

JsDove force-pushed the schemacache branch 3 times, most recently from 580fb0c to f69e405 Compare January 9, 2025 05:52

JsDove force-pushed the schemacache branch 4 times, most recently from 59713cc to 61d41bc Compare January 9, 2025 11:23

mergify bot added the ci-passed label Jan 9, 2025

JsDove force-pushed the schemacache branch from 61d41bc to 94bc70a Compare January 10, 2025 08:25

mergify bot added ci-passed and removed ci-passed labels Jan 10, 2025

JsDove mentioned this pull request Jan 17, 2025

enhance: [2.4]Add schema update time verification for insert and upsert to use cache #39385

Closed

JsDove force-pushed the schemacache branch from 1028df1 to e1d9f16 Compare January 17, 2025 08:32

mergify bot removed the ci-passed label Jan 17, 2025

JsDove force-pushed the schemacache branch from e1d9f16 to 11672da Compare January 17, 2025 08:43

liliu-z reviewed Jan 17, 2025

View reviewed changes

sre-ci-robot assigned liliu-z Jan 17, 2025

sre-ci-robot added lgtm approved labels Jan 17, 2025

sre-ci-robot removed the lgtm label Jan 17, 2025

JsDove force-pushed the schemacache branch from 683e3e7 to 26772ea Compare January 17, 2025 10:37

JsDove mentioned this pull request Jan 17, 2025

enhance: [2.4]Add schema update time verification for insert and upsert to use cache #39405

Merged

mergify bot added the ci-passed label Jan 17, 2025

xiaofan-luan reviewed Jan 19, 2025

View reviewed changes

JsDove force-pushed the schemacache branch from 26772ea to a8d5aca Compare January 20, 2025 01:57

mergify bot removed the ci-passed label Jan 20, 2025

mergify bot added the ci-passed label Jan 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhance: Add schema update time verification for insert and upsert to use cache #39096

enhance: Add schema update time verification for insert and upsert to use cache #39096

JsDove commented Jan 8, 2025

mergify bot commented Jan 8, 2025

codecov bot commented Jan 8, 2025 •

edited

Loading

mergify bot commented Jan 9, 2025

mergify bot commented Jan 9, 2025

mergify bot commented Jan 9, 2025

JsDove commented Jan 9, 2025

JsDove commented Jan 9, 2025

liliu-z left a comment

mergify bot commented Jan 17, 2025

JsDove commented Jan 17, 2025

sre-ci-robot commented Jan 17, 2025

mergify bot commented Jan 17, 2025

mergify bot commented Jan 17, 2025

xiaofan-luan Jan 19, 2025

xiaofan-luan commented Jan 19, 2025

sre-ci-robot commented Jan 19, 2025

mergify bot commented Jan 20, 2025

JsDove commented Jan 20, 2025

mergify bot commented Jan 20, 2025

JsDove commented Jan 20, 2025

enhance: Add schema update time verification for insert and upsert to use cache #39096

Are you sure you want to change the base?

enhance: Add schema update time verification for insert and upsert to use cache #39096

Conversation

JsDove commented Jan 8, 2025

mergify bot commented Jan 8, 2025

codecov bot commented Jan 8, 2025 • edited Loading

Codecov Report

mergify bot commented Jan 9, 2025

mergify bot commented Jan 9, 2025

mergify bot commented Jan 9, 2025

JsDove commented Jan 9, 2025

JsDove commented Jan 9, 2025

liliu-z left a comment

Choose a reason for hiding this comment

mergify bot commented Jan 17, 2025

JsDove commented Jan 17, 2025

sre-ci-robot commented Jan 17, 2025

mergify bot commented Jan 17, 2025

mergify bot commented Jan 17, 2025

xiaofan-luan Jan 19, 2025

Choose a reason for hiding this comment

xiaofan-luan commented Jan 19, 2025

sre-ci-robot commented Jan 19, 2025

mergify bot commented Jan 20, 2025

JsDove commented Jan 20, 2025

mergify bot commented Jan 20, 2025

JsDove commented Jan 20, 2025

codecov bot commented Jan 8, 2025 •

edited

Loading