Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: mark bm25 sparse field as has row data to skip load row data #39078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Jan 8, 2025

Skip load row data of bm25 sparse field, because it's forbidden to return.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 8, 2025
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.68%. Comparing base (a89ac86) to head (d468f5f).
Report is 26 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a89ac86) and HEAD (d468f5f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (a89ac86) HEAD (d468f5f)
3 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39078       +/-   ##
===========================================
- Coverage   81.15%   69.68%   -11.47%     
===========================================
  Files        1389      296     -1093     
  Lines      196880    26673   -170207     
===========================================
- Hits       159776    18588   -141188     
+ Misses      31520     8085    -23435     
+ Partials     5584        0     -5584     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.68% <ø> (+0.09%) ⬆️
Go ∅ <ø> (∅)

see 1106 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 10, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aoiasd
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 13, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants