-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support phrase match query #38869
Conversation
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
…d test Signed-off-by: SpadeA-Tang <[email protected]>
@SpadeA-Tang Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
@SpadeA-Tang go-sdk check failed, comment |
@SpadeA-Tang cpp-unit-test check failed, comment |
rerun go-sdk |
Signed-off-by: SpadeA-Tang <[email protected]>
@SpadeA-Tang go-sdk check failed, comment |
@SpadeA-Tang E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38869 +/- ##
==========================================
- Coverage 81.16% 81.12% -0.05%
==========================================
Files 1395 1395
Lines 197277 197352 +75
==========================================
- Hits 160124 160095 -29
- Misses 31539 31619 +80
- Partials 5614 5638 +24
|
Signed-off-by: SpadeA-Tang <[email protected]>
@@ -69,7 +69,8 @@ enum ErrorCode { | |||
FollyCancel = 2038, | |||
OutOfRange = 2039, | |||
GcpNativeError = 2040, | |||
TextIndexNotFound = 2041, | |||
InvalidParameter = 2041, | |||
TextIndexNotFound = 2042, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep TextIndexNotFound as 2041.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Signed-off-by: SpadeA-Tang <[email protected]>
@SpadeA-Tang cpp-unit-test check failed, comment |
@SpadeA-Tang E2e jenkins job failed, comment |
Signed-off-by: SpadeA-Tang <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, SpadeA-Tang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The relevant issue: #38930