Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support phrase match query #38869

Merged
merged 18 commits into from
Jan 12, 2025
Merged

Conversation

SpadeA-Tang
Copy link
Contributor

@SpadeA-Tang SpadeA-Tang commented Dec 31, 2024

The relevant issue: #38930

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

@SpadeA-Tang Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@SpadeA-Tang SpadeA-Tang marked this pull request as draft December 31, 2024 04:07
@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Dec 31, 2024
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
@SpadeA-Tang SpadeA-Tang marked this pull request as ready for review January 2, 2025 05:45
@sre-ci-robot sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label Jan 2, 2025
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Copy link
Contributor

mergify bot commented Jan 2, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@SpadeA-Tang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

rerun go-sdk

Signed-off-by: SpadeA-Tang <[email protected]>
Copy link
Contributor

mergify bot commented Jan 2, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 73.75000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (826b726) to head (554f2fd).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/parser/planparserv2/parser_visitor.go 70.96% 6 Missing and 3 partials ⚠️
internal/core/src/expr/ITypeExpr.h 45.45% 6 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.cpp 76.47% 4 Missing ⚠️
internal/core/src/index/TextMatchIndex.cpp 77.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38869      +/-   ##
==========================================
- Coverage   81.16%   81.12%   -0.05%     
==========================================
  Files        1395     1395              
  Lines      197277   197352      +75     
==========================================
- Hits       160124   160095      -29     
- Misses      31539    31619      +80     
- Partials     5614     5638      +24     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.64% <72.72%> (+<0.01%) ⬆️
Go 83.05% <75.00%> (-0.06%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/common/EasyAssert.h 84.61% <ø> (ø)
internal/core/src/query/PlanProto.cpp 89.04% <100.00%> (+0.22%) ⬆️
internal/parser/planparserv2/show_visitor.go 94.11% <100.00%> (+0.19%) ⬆️
internal/core/src/index/TextMatchIndex.cpp 46.48% <77.77%> (+1.60%) ⬆️
internal/core/src/exec/expression/UnaryExpr.cpp 84.23% <76.47%> (-0.36%) ⬇️
internal/core/src/expr/ITypeExpr.h 45.91% <45.45%> (-0.22%) ⬇️
internal/parser/planparserv2/parser_visitor.go 85.86% <70.96%> (-0.40%) ⬇️

... and 25 files with indirect coverage changes

Signed-off-by: SpadeA-Tang <[email protected]>
@mergify mergify bot added the ci-passed label Jan 8, 2025
@@ -69,7 +69,8 @@ enum ErrorCode {
FollyCancel = 2038,
OutOfRange = 2039,
GcpNativeError = 2040,
TextIndexNotFound = 2041,
InvalidParameter = 2041,
TextIndexNotFound = 2042,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep TextIndexNotFound as 2041.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Signed-off-by: SpadeA-Tang <[email protected]>
@mergify mergify bot removed the ci-passed label Jan 9, 2025
Copy link
Contributor

mergify bot commented Jan 9, 2025

@SpadeA-Tang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: SpadeA-Tang <[email protected]>
@mergify mergify bot added the ci-passed label Jan 10, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 12, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SpadeA-Tang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 032292a into milvus-io:master Jan 12, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants