Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix directory confusion between indexnode and querynode #38628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Dec 20, 2024

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 20, 2024
@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch 4 times, most recently from 55656c5 to 2f9bca9 Compare December 20, 2024 09:55
Copy link
Contributor

mergify bot commented Dec 20, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 20, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 20, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 23, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from 2f9bca9 to ac55af4 Compare December 25, 2024 12:30
Copy link
Contributor

mergify bot commented Dec 25, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 25, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 71.28713% with 29 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (826b726) to head (4d17234).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/common/Common.h 40.00% 6 Missing ⚠️
internal/core/src/storage/DiskFileManagerImpl.cpp 72.22% 5 Missing ⚠️
internal/querynodev2/server.go 50.00% 4 Missing and 1 partial ⚠️
internal/core/src/storage/storage_c.cpp 20.00% 4 Missing ⚠️
internal/core/src/index/VectorDiskIndex.cpp 71.42% 2 Missing ⚠️
internal/core/src/segcore/load_index_c.cpp 33.33% 2 Missing ⚠️
...rnal/core/src/storage/LocalChunkManagerSingleton.h 89.47% 2 Missing ⚠️
internal/indexnode/task_index.go 0.00% 2 Missing ⚠️
internal/core/src/segcore/segment_c.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38628      +/-   ##
==========================================
- Coverage   81.16%   81.14%   -0.02%     
==========================================
  Files        1395     1395              
  Lines      197277   197320      +43     
==========================================
  Hits       160124   160124              
- Misses      31539    31582      +43     
  Partials     5614     5614              
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.63% <71.79%> (-0.01%) ⬇️
Go 83.08% <69.56%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/index/Index.h 100.00% <ø> (ø)
internal/core/src/index/InvertedIndexTantivy.cpp 92.75% <100.00%> (+0.02%) ⬆️
internal/core/src/storage/DiskFileManagerImpl.h 60.00% <ø> (ø)
internal/core/src/storage/FileManager.h 64.81% <100.00%> (+5.24%) ⬆️
internal/core/src/storage/MemFileManagerImpl.cpp 79.56% <100.00%> (+0.22%) ⬆️
internal/core/src/storage/MmapChunkManager.cpp 84.00% <100.00%> (ø)
internal/indexnode/indexnode.go 78.47% <100.00%> (ø)
internal/querynodev2/segments/segment.go 65.19% <100.00%> (+0.03%) ⬆️
internal/querynodev2/segments/segment_loader.go 72.91% <100.00%> (-0.12%) ⬇️
internal/util/initcore/init_core.go 87.03% <100.00%> (+0.16%) ⬆️
... and 9 more

... and 32 files with indirect coverage changes

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from ac55af4 to b314cb5 Compare December 26, 2024 00:21
Copy link
Contributor

mergify bot commented Dec 26, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from b314cb5 to 0cc92ed Compare January 6, 2025 09:46
Copy link
Contributor

mergify bot commented Jan 6, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from 0cc92ed to a310d1a Compare January 6, 2025 11:35
Copy link
Contributor

mergify bot commented Jan 6, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from a310d1a to 5670bae Compare January 6, 2025 13:21
@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from 33a9124 to 76a3606 Compare January 7, 2025 06:39
Copy link
Contributor

mergify bot commented Jan 7, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from 76a3606 to fcb5d6a Compare January 7, 2025 09:56
Copy link
Contributor

mergify bot commented Jan 7, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch 2 times, most recently from 6a47a19 to bb3db96 Compare January 7, 2025 11:45
Copy link
Contributor

mergify bot commented Jan 7, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from bb3db96 to 964b386 Compare January 8, 2025 08:51
Copy link
Contributor

mergify bot commented Jan 8, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from 964b386 to 36e62d4 Compare January 8, 2025 09:43
Copy link
Contributor

mergify bot commented Jan 8, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 8, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 8, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch 2 times, most recently from b7c1a7b to d21347e Compare January 9, 2025 02:24
Copy link
Contributor

mergify bot commented Jan 9, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jan 9, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 9, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jan 9, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 9, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from d21347e to e2f05cc Compare January 10, 2025 07:18
Copy link
Contributor

mergify bot commented Jan 10, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from e2f05cc to 4d17234 Compare January 10, 2025 10:07
@mergify mergify bot added the ci-passed label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants