fix: Convert C-Style Casts to C++-Style Type Casts

[abd-770]

Issue:
#35900

Description:
This pull request replaces the instances of C-style casting in the codebase with C++ style type casting (static_cast, const_cast, and reinterpret_cast). This change is aimed at:

1. Vulnerability Fix: Fixes the casting vulnerability from the static scan.
2. Type Safety: C++-style casts are more explicit and specific than C-style casts
3. Readability: conveys explicitly what kind of cast is being performed
4. Adheres to the ES.49 C++ Core Guidelines

[mergify]

@abd-770 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

[mergify]

@abd-770

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

1. Title Format: The PR title must begin with one of these prefixes:

• feat: for introducing a new feature.
• fix: for bug fixes.
• enhance: for improvements to existing functionality.
• test: for add tests to existing functionality.
• doc: for modifying documentation.
• auto: for the pull request from bot.

2. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (a5e0a56) to head (3806754).
Report is 270 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #36416      +/-   ##
==========================================
+ Coverage   81.05%   82.97%   +1.91%     
==========================================
  Files        1370     1081     -289     
  Lines      191486   165618   -25868     
==========================================
- Hits       155215   137421   -17794     
+ Misses      30788    22718    -8070     
+ Partials     5483     5479       -4     

Components	Coverage Δ
Client	73.67% <ø> (ø)
Core	∅ <ø> (∅)
Go	83.23% <ø> (-0.01%)	⬇️

see 314 files with indirect coverage changes

[alexanderguzhva]

to @abd-770 and whoever reviews these changes.

These automated changes need to be reviewed VERY CAREFULLY and altered manually.
For example, I see

    std::vector<uint8_t> vals;
    auto execute_sub_batch = [](Index* index_ptr,
                                const std::vector<uint8_t>& vals) {
        TermIndexFunc<bool> func;

        return std::move(func(index_ptr, vals.size(), (bool*)vals.data()));
    };

    auto res = ProcessIndexChunks<bool>(execute_sub_batch, vals);

got changed into

    std::vector<uint8_t> vals;
    auto execute_sub_batch = [](Index* index_ptr,
                                const std::vector<uint8_t>& vals) {
        TermIndexFunc<bool> func;

        return std::move(func(index_ptr, vals.size(), 
                      const_cast<bool*>(static_cast<const bool*>(
                          static_cast<const void*>(vals.data())
                      ))));
    };

    auto res = ProcessIndexChunks<bool>(execute_sub_batch, vals);

while at a first glance the problem may be fixed by changing const std::vector<uint8_t>& vals to std::vector<uint8_t>& vals

[mergify]

@abd-770 go-sdk check failed, comment rerun go-sdk can trigger the job again.

[mergify]

@abd-770 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[abd-770]

rerun go-sdk

[abd-770]

/run-cpu-e2e

[mergify]

@abd-770 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[mergify]

@abd-770 go-sdk check failed, comment rerun go-sdk can trigger the job again.

[abd-770]

@alexanderguzhva can you tag someone from the community to review this pr. Thanks

[mergify]

@abd-770 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[mergify]

@abd-770 go-sdk check failed, comment rerun go-sdk can trigger the job again.

[alexanderguzhva]

@abd-770 would it be possible to run clang-format in order to fix the formatting? thanks

[abd-770]

@alexanderguzhva I have made changes to the code based on your first review comment.
The rest, I have added respective reasons on the changes.

[abd-770]

@alexanderguzhva @godchen0212 @bigsheeper any updates?

[alexanderguzhva]

@abd-770 I gave all of my comments. Waiting for my colleagues.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

[abd-770]

Hey @alexanderguzhva @godchen0212 @bigsheeper ,
Can you guys review this pr? It's been over a month now, and marked stale.

[mergify]

@abd-770 go-sdk check failed, comment rerun go-sdk can trigger the job again.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

[alexanderguzhva]

/reopen

[liliu-z]

/reopen

[sre-ci-robot]

@liliu-z: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liliu-z]

/approve
@abd-770 sorry for this late response. This change looks good to me, plz resolve the conflicts before checking in

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abd-770, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• internal/core/OWNERS [liliu-z]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment