fix: some comment

Signed-off-by: chyezh <[email protected]>

internal/core/src/index/BitmapIndex.cpp

@@ -286,20 +286,15 @@ BitmapIndex<T>::Serialize(const Config& config) {
 }
 
 template <typename T>
-CreateIndexResultPtr
+IndexStatsPtr
 BitmapIndex<T>::Upload(const Config& config) {
     auto binary_set = Serialize(config);
 
     file_manager_->AddFile(binary_set);
 
     auto remote_path_to_size = file_manager_->GetRemotePathsToFileSize();
-    std::vector<SerializedIndexFileInfo> index_files;
-    index_files.reserve(remote_path_to_size.size());
-    for (auto& file : remote_path_to_size) {
-        index_files.emplace_back(file.first, file.second);
-    }
-    return CreateIndexResult::New(file_manager_->GetAddedTotalMemSize(),
-                                  std::move(index_files));
+    return IndexStats::NewFromSizeMap(file_manager_->GetAddedTotalMemSize(),
+                                      remote_path_to_size);
 }
 
 template <typename T>

internal/core/src/index/BitmapIndex.h

@@ -114,7 +114,7 @@ class BitmapIndex : public ScalarIndex<T> {
         return Count();
     }
 
-    CreateIndexResultPtr
+    IndexStatsPtr
     Upload(const Config& config = {}) override;
 
     const bool

internal/core/src/index/HybridScalarIndex.cpp

@@ -298,7 +298,7 @@ HybridScalarIndex<T>::SerializeIndexType() {
 }
 
 template <typename T>
-CreateIndexResultPtr
+IndexStatsPtr
 HybridScalarIndex<T>::Upload(const Config& config) {
     auto internal_index = GetInternalIndex();
     auto index_ret = internal_index->Upload(config);

internal/core/src/index/HybridScalarIndex.h

@@ -153,7 +153,7 @@ class HybridScalarIndex : public ScalarIndex<T> {
         return internal_index_->HasRawData();
     }
 
-    CreateIndexResultPtr
+    IndexStatsPtr
     Upload(const Config& config = {}) override;
 
  private:

internal/core/src/index/Index.h

@@ -26,7 +26,7 @@
 #include "common/Tracer.h"
 #include "common/Types.h"
 #include "index/Meta.h"
-#include "index/CreateIndexResult.h"
+#include "index/IndexStats.h"
 
 namespace milvus::index {
 
@@ -58,7 +58,7 @@ class IndexBase {
     virtual int64_t
     Count() = 0;
 
-    virtual CreateIndexResultPtr
+    virtual IndexStatsPtr
     Upload(const Config& config = {}) = 0;
 
     virtual const bool

internal/core/src/index/CreateIndexResult.cpp → internal/core/src/index/IndexStats.cpp

@@ -9,45 +9,54 @@
 // is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
 // or implied. See the License for the specific language governing permissions and limitations under the License
 
-#include "index/CreateIndexResult.h"
+#include "index/IndexStats.h"
 
 namespace milvus::index {
 
-CreateIndexResultPtr
-CreateIndexResult::New(
-    int64_t mem_size,
-    std::vector<SerializedIndexFileInfo>&& serialized_index_infos) {
-    return std::unique_ptr<CreateIndexResult>(
-        new CreateIndexResult(mem_size, std::move(serialized_index_infos)));
+IndexStatsPtr
+IndexStats::NewFromSizeMap(int64_t mem_size,
+                           std::map<std::string, int64_t>& index_size_map) {
+    std::vector<SerializedIndexFileInfo> serialized_index_infos;
+    serialized_index_infos.reserve(index_size_map.size());
+    for (auto& file : index_size_map) {
+        serialized_index_infos.emplace_back(file.first, file.second);
+    }
+    return IndexStats::New(mem_size, std::move(serialized_index_infos));
+}
+
+IndexStatsPtr
+IndexStats::New(int64_t mem_size,
+                std::vector<SerializedIndexFileInfo>&& serialized_index_infos) {
+    return std::unique_ptr<IndexStats>(
+        new IndexStats(mem_size, std::move(serialized_index_infos)));
 }
 
-CreateIndexResult::CreateIndexResult(
+IndexStats::IndexStats(
     int64_t mem_size,
     std::vector<SerializedIndexFileInfo>&& serialized_index_infos)
     : mem_size_(mem_size), serialized_index_infos_(serialized_index_infos) {
 }
 
 void
-CreateIndexResult::AppendSerializedIndexFileInfo(
-    SerializedIndexFileInfo&& info) {
+IndexStats::AppendSerializedIndexFileInfo(SerializedIndexFileInfo&& info) {
     serialized_index_infos_.push_back(std::move(info));
 }
 
 void
-CreateIndexResult::SerializeAt(milvus::ProtoLayout* layout) {
-    milvus::proto::cgo::CreateIndexResult result;
+IndexStats::SerializeAt(milvus::ProtoLayout* layout) {
+    milvus::proto::cgo::IndexStats result;
     result.set_mem_size(mem_size_);
     for (auto& info : serialized_index_infos_) {
         auto serialized_info = result.add_serialized_index_infos();
         serialized_info->set_file_name(info.file_name);
         serialized_info->set_file_size(info.file_size);
     }
     AssertInfo(layout->SerializeAndHoldProto(result),
-               "marshal CreateIndexResult failed");
+               "marshal IndexStats failed");
 }
 
 std::vector<std::string>
-CreateIndexResult::GetIndexFiles() const {
+IndexStats::GetIndexFiles() const {
     std::vector<std::string> files;
     for (auto& info : serialized_index_infos_) {
         files.push_back(info.file_name);
@@ -56,12 +65,12 @@ CreateIndexResult::GetIndexFiles() const {
 }
 
 int64_t
-CreateIndexResult::GetMemSize() const {
+IndexStats::GetMemSize() const {
     return mem_size_;
 }
 
 int64_t
-CreateIndexResult::GetSerializedSize() const {
+IndexStats::GetSerializedSize() const {
     int64_t size = 0;
     for (auto& info : serialized_index_infos_) {
         size += info.file_size;

internal/core/src/index/CreateIndexResult.h → internal/core/src/index/IndexStats.h

@@ -28,26 +28,30 @@ class SerializedIndexFileInfo {
     int64_t file_size;
 };
 
-class CreateIndexResult;
+class IndexStats;
 
-using CreateIndexResultPtr = std::unique_ptr<CreateIndexResult>;
+using IndexStatsPtr = std::unique_ptr<IndexStats>;
 
-class CreateIndexResult {
+class IndexStats {
  public:
-    // Create a new CreateIndexResult instance.
-    static CreateIndexResultPtr
+    static IndexStatsPtr
+    NewFromSizeMap(int64_t mem_size,
+                   std::map<std::string, int64_t>& index_size_map);
+
+    // Create a new IndexStats instance.
+    static IndexStatsPtr
     New(int64_t mem_size,
         std::vector<SerializedIndexFileInfo>&& serialized_index_infos);
 
-    CreateIndexResult(const CreateIndexResult&) = delete;
+    IndexStats(const IndexStats&) = delete;
 
-    CreateIndexResult(CreateIndexResult&&) = delete;
+    IndexStats(IndexStats&&) = delete;
 
-    CreateIndexResult&
-    operator=(const CreateIndexResult&) = delete;
+    IndexStats&
+    operator=(const IndexStats&) = delete;
 
-    CreateIndexResult&
-    operator=(CreateIndexResult&&) = delete;
+    IndexStats&
+    operator=(IndexStats&&) = delete;
 
     // Append a new serialized index file info into the result.
     void
@@ -67,9 +71,8 @@ class CreateIndexResult {
     GetSerializedSize() const;
 
  private:
-    CreateIndexResult(
-        int64_t mem_size,
-        std::vector<SerializedIndexFileInfo>&& serialized_index_infos);
+    IndexStats(int64_t mem_size,
+               std::vector<SerializedIndexFileInfo>&& serialized_index_infos);
 
     int64_t mem_size_;
     std::vector<SerializedIndexFileInfo> serialized_index_infos_;

internal/core/src/index/InvertedIndexTantivy.cpp

@@ -136,7 +136,7 @@ InvertedIndexTantivy<T>::Serialize(const Config& config) {
 }
 
 template <typename T>
-CreateIndexResultPtr
+IndexStatsPtr
 InvertedIndexTantivy<T>::Upload(const Config& config) {
     finish();
 
@@ -172,10 +172,9 @@ InvertedIndexTantivy<T>::Upload(const Config& config) {
     for (auto& file : remote_mem_path_to_size) {
         index_files.emplace_back(file.first, file.second);
     }
-    return CreateIndexResult::New(
-        mem_file_manager_->GetAddedTotalMemSize() +
-            disk_file_manager_->GetAddedTotalFileSize(),
-        std::move(index_files));
+    return IndexStats::New(mem_file_manager_->GetAddedTotalMemSize() +
+                               disk_file_manager_->GetAddedTotalFileSize(),
+                           std::move(index_files));
 }
 
 template <typename T>

internal/core/src/index/InvertedIndexTantivy.h

@@ -89,7 +89,7 @@ class InvertedIndexTantivy : public ScalarIndex<T> {
     BinarySet
     Serialize(const Config& config) override;
 
-    CreateIndexResultPtr
+    IndexStatsPtr
     Upload(const Config& config = {}) override;
 
     /*

internal/core/src/index/ScalarIndexSort.cpp

@@ -151,19 +151,14 @@ ScalarIndexSort<T>::Serialize(const Config& config) {
 }
 
 template <typename T>
-CreateIndexResultPtr
+IndexStatsPtr
 ScalarIndexSort<T>::Upload(const Config& config) {
     auto binary_set = Serialize(config);
     file_manager_->AddFile(binary_set);
 
     auto remote_paths_to_size = file_manager_->GetRemotePathsToFileSize();
-    std::vector<SerializedIndexFileInfo> index_files;
-    index_files.reserve(remote_paths_to_size.size());
-    for (auto& file : remote_paths_to_size) {
-        index_files.emplace_back(file.first, file.second);
-    }
-    return CreateIndexResult::New(file_manager_->GetAddedTotalMemSize(),
-                                  std::move(index_files));
+    return IndexStats::NewFromSizeMap(file_manager_->GetAddedTotalMemSize(),
+                                      remote_paths_to_size);
 }
 
 template <typename T>

internal/core/src/index/ScalarIndexSort.h

@@ -90,7 +90,7 @@ class ScalarIndexSort : public ScalarIndex<T> {
         return (int64_t)data_.size();
     }
 
-    CreateIndexResultPtr
+    IndexStatsPtr
     Upload(const Config& config = {}) override;
 
     const bool

internal/core/src/index/StringIndexMarisa.cpp

@@ -174,19 +174,14 @@ StringIndexMarisa::Serialize(const Config& config) {
     return res_set;
 }
 
-CreateIndexResultPtr
+IndexStatsPtr
 StringIndexMarisa::Upload(const Config& config) {
     auto binary_set = Serialize(config);
     file_manager_->AddFile(binary_set);
 
     auto remote_paths_to_size = file_manager_->GetRemotePathsToFileSize();
-    std::vector<SerializedIndexFileInfo> index_files;
-    index_files.reserve(remote_paths_to_size.size());
-    for (auto& file : remote_paths_to_size) {
-        index_files.emplace_back(file.first, file.second);
-    }
-    return CreateIndexResult::New(file_manager_->GetAddedTotalMemSize(),
-                                  std::move(index_files));
+    return IndexStats::NewFromSizeMap(file_manager_->GetAddedTotalMemSize(),
+                                      remote_paths_to_size);
 }
 
 void

internal/core/src/index/StringIndexMarisa.h

@@ -92,7 +92,7 @@ class StringIndexMarisa : public StringIndex {
     std::optional<std::string>
     Reverse_Lookup(size_t offset) const override;
 
-    CreateIndexResultPtr
+    IndexStatsPtr
     Upload(const Config& config = {}) override;
 
     const bool

internal/core/src/index/TextMatchIndex.cpp

@@ -78,7 +78,7 @@ TextMatchIndex::TextMatchIndex(const storage::FileManagerContext& ctx)
     d_type_ = TantivyDataType::Text;
 }
 
-CreateIndexResultPtr
+IndexStatsPtr
 TextMatchIndex::Upload(const Config& config) {
     finish();
 
@@ -104,6 +104,7 @@ TextMatchIndex::Upload(const Config& config) {
     mem_file_manager_->AddFile(binary_set);
     auto remote_mem_path_to_size =
         mem_file_manager_->GetRemotePathsToFileSize();
+
     std::vector<SerializedIndexFileInfo> index_files;
     index_files.reserve(remote_paths_to_size.size() +
                         remote_mem_path_to_size.size());
@@ -113,10 +114,9 @@ TextMatchIndex::Upload(const Config& config) {
     for (auto& file : remote_mem_path_to_size) {
         index_files.emplace_back(file.first, file.second);
     }
-    return CreateIndexResult::New(
-        mem_file_manager_->GetAddedTotalMemSize() +
-            disk_file_manager_->GetAddedTotalFileSize(),
-        std::move(index_files));
+    return IndexStats::New(mem_file_manager_->GetAddedTotalMemSize() +
+                               disk_file_manager_->GetAddedTotalFileSize(),
+                           std::move(index_files));
 }
 
 void

internal/core/src/index/TextMatchIndex.h

@@ -15,7 +15,7 @@
 #include <boost/filesystem.hpp>
 
 #include "index/InvertedIndexTantivy.h"
-#include "index/CreateIndexResult.h"
+#include "index/IndexStats.h"
 
 namespace milvus::index {
 
@@ -40,7 +40,7 @@ class TextMatchIndex : public InvertedIndexTantivy<std::string> {
     explicit TextMatchIndex(const storage::FileManagerContext& ctx);
 
  public:
-    CreateIndexResultPtr
+    IndexStatsPtr
     Upload(const Config& config) override;
 
     void

internal/core/src/index/VectorDiskIndex.cpp

@@ -115,7 +115,7 @@ VectorDiskAnnIndex<T>::Load(milvus::tracer::TraceContext ctx,
 }
 
 template <typename T>
-CreateIndexResultPtr
+IndexStatsPtr
 VectorDiskAnnIndex<T>::Upload(const Config& config) {
     BinarySet ret;
     auto stat = index_.Serialize(ret);
@@ -124,13 +124,8 @@ VectorDiskAnnIndex<T>::Upload(const Config& config) {
                   "failed to serialize index, " + KnowhereStatusString(stat));
     }
     auto remote_paths_to_size = file_manager_->GetRemotePathsToFileSize();
-    std::vector<SerializedIndexFileInfo> index_files;
-    index_files.reserve(remote_paths_to_size.size());
-    for (auto& file : remote_paths_to_size) {
-        index_files.emplace_back(file.first, file.second);
-    }
-    return CreateIndexResult::New(file_manager_->GetAddedTotalFileSize(),
-                                  std::move(index_files));
+    return IndexStats::NewFromSizeMap(file_manager_->GetAddedTotalFileSize(),
+                                      remote_paths_to_size);
 }
 
 template <typename T>

internal/core/src/index/VectorDiskIndex.h

@@ -46,7 +46,7 @@ class VectorDiskAnnIndex : public VectorIndex {
         return binary_set;
     }
 
-    CreateIndexResultPtr
+    IndexStatsPtr
     Upload(const Config& config = {}) override;
 
     int64_t