Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radial cutoff for the adjacency matrix in egnn #73

Merged
merged 15 commits into from
Oct 11, 2024
Merged

Conversation

sblackburn86
Copy link
Collaborator

@sblackburn86 sblackburn86 commented Aug 22, 2024

Use the MACE implementation of the adjacency matrix calculation in EGNN. The distance cutoff to determine an edge is based on the original 3D positions, not the uplifted 6D positions.

@sblackburn86 sblackburn86 requested a review from rousseab October 4, 2024 18:27
Copy link
Collaborator

@rousseab rousseab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make some trivial suggestions. Once that's done, it's ready to merge.

@sblackburn86 sblackburn86 merged commit 91e3f7c into main Oct 11, 2024
1 check passed
@sblackburn86 sblackburn86 deleted the egnn_radial_cutoff branch October 22, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants