Merge branch 'master' into fix-produce-fake-data

clockwork_frontend_test/test_dashboard.py

@@ -173,8 +173,7 @@ def _check_dashboard_table_sorting(
     # Remove last column (row order) to get only expected content.
     content = [row[:-1] for row in sorted_content]
     SORTED_CONTENT = content
-    # We assume DASHBOARD_TABLE_CONTENT is not initially sorted anyway.
-    assert content != DASHBOARD_TABLE_CONTENT
+
     # Expected content is now ready for checking.
     table = page.locator("table#dashboard_table")
     headers = table.locator("thead tr th")

scripts/insert_hardcoded_values.py

@@ -81,15 +81,6 @@ def get_job_user_props_hardcoded_values(fake_data: dict):
     ]
 
 
-def ensure_admin_users(fake_data: dict):
-    """Make sure there is at least 1 fake admin."""
-    users = fake_data["users"]
-    admin_users = [user for user in users if user.get("admin_access", False)]
-    if not admin_users and users:
-        users[0]["admin_access"] = True
-        assert [user for user in fake_data["users"] if user.get("admin_access", False)]
-
-
 def ensure_job_arrays(fake_data: dict):
     """Make sure some fake jobs belong to valid job arrays."""
     jobs_with_array_id = [
@@ -141,9 +132,6 @@ def main(argv):
     # Insert fake job user props
     fake_data["job_user_props"] = get_job_user_props_hardcoded_values(fake_data)
 
-    # Make sure there are some admin users
-    ensure_admin_users(fake_data)
-
     # Make sure some jobs are in valid job arrays
     ensure_job_arrays(fake_data)
 

test_common/fake_data.json

@@ -11,8 +11,7 @@
         "nbr_items_per_page": 40,
         "dark_mode": false,
         "language": "en"
-      },
-      "personal_picture": "https://mila.quebec/wp-content/uploads/2019/08/guillaume_alain_400x700-400x400.jpg"
+      }
     },
     {
       "mila_email_username": "[email protected]",