-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit to prevent CI fails due to linting #42
Open
lebrice
wants to merge
2
commits into
master
Choose a base branch
from
lebrice/pre-commit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# See https://pre-commit.com for more information | ||
# See https://pre-commit.com/hooks.html for more hooks | ||
repos: | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v3.2.0 | ||
hooks: | ||
- id: trailing-whitespace | ||
- id: end-of-file-fixer | ||
- id: check-yaml | ||
- id: check-added-large-files | ||
- repo: https://github.com/psf/black | ||
rev: 23.1.0 | ||
hooks: | ||
- id: black | ||
- repo: https://github.com/pycqa/isort | ||
rev: 5.12.0 | ||
hooks: | ||
- id: isort | ||
name: isort (python) | ||
args: ["--profile", "black", "--filter-files"] | ||
|
||
# IDEA: Might want to look into poetry-specific hooks as well: | ||
# https://python-poetry.org/docs/master/pre-commit-hooks/ | ||
|
||
# NOTE: Does the same thing, but doesn't require hard-coding a version (uses poetry to run the | ||
# hook). This takes much longer (like 7 secs without pylint, and 25 seconds with pylint) vs <1 sec. | ||
# - repo: local | ||
# hooks: | ||
# - id: black | ||
# name: black | ||
# entry: poetry | ||
# language: system | ||
# types: [python] | ||
# pass_filenames: false | ||
# args: ["run", "tox", "-e", "black_fix"] | ||
# - id: isort | ||
# name: isort | ||
# entry: poetry | ||
# language: system | ||
# types: [python] | ||
# pass_filenames: false | ||
# args: ["run", "tox", "-e", "isort_fix"] | ||
# - id: pylint | ||
# name: pylint | ||
# entry: poetry | ||
# language: system | ||
# types: [python] | ||
# pass_filenames: false | ||
# args: ["run", "tox", "-e", "lint"] |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a besoin de spécifier une version de black dans le pre-commit en plus du poetry.lock?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouais, la solution en commentaire plus bas n'a pas besoin de le faire, mais ça prend beaucoup plus longtemps à rouler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouin, j'aime pas trop que ça soit dupliqué et donc éventuellement désynchronisé, avec un pre-commit qui génère qqc qui plante avec
tox -e black
. L'idéal serait de rouler precommit danstox
comme t'as fait dans orion.