Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit to prevent CI fails due to linting #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lebrice
Copy link
Contributor

@lebrice lebrice commented Mar 14, 2023

No description provided.

hooks:
- id: black
- repo: https://github.com/pycqa/isort
rev: 5.12.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a besoin de spécifier une version de black dans le pre-commit en plus du poetry.lock?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouais, la solution en commentaire plus bas n'a pas besoin de le faire, mais ça prend beaucoup plus longtemps à rouler

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouin, j'aime pas trop que ça soit dupliqué et donc éventuellement désynchronisé, avec un pre-commit qui génère qqc qui plante avec tox -e black. L'idéal serait de rouler precommit dans tox comme t'as fait dans orion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants