-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git feature #30
Git feature #30
Conversation
This looks great too! Thanks. I'll take a proper look as soon as I can. In the meantime, the test system is very hacky but it should be self explanatory. You create a directory for the package and directories for what the target look like once it's installed and after it's uninstalled. In this case you'd presumably want to test .gitignored files and untracked files do not make it into the installation if |
I have added a test for the git feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one issue that does need fixing, but should be pretty straightforward. Let me know if you have any trouble with my request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work now
I'm not sure if I have any more tasks to do in this "review request" (first timer). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Tested on macOS.
I think this is ready to merge once you add the quotes (see inline comment) and squash into a single commit. (I think the standard github workflow for that is something like git rebase -i main
to tidy up, and then git push -f
once you're done to update this PR. Let me know if you have any difficulties.)
fdc9b18
to
98af138
Compare
Thank you for your contribution! |
Hi,
This is my attempt to implement the github feature as in #27 .
I added the
-g
command argument to usegit ls-files
as a file and folder factory.It works in my environment and passed all test in your test folder (after adding
-g
tostowsh
in allrun
scripts).Yet to be done: add permanently tests to the test suite.