New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added withMsg to History and created exec/hlearn-allknn-bench.hs #58

Closed

tonyday567 wants to merge 1 commit into mikeizbicki:ghc7.10 from tonyday567:history-time

Contributor

tonyday567 commented Jun 16, 2015

I created a new executable (hlearn-allknn-bench.hs) rather than edit the original.
There's a few gotchas/fails with what I have so far:

I couldnt work out what to do with the disableMultithreading so I deleted it.
The new timings look like they're being reported 1 behind. Don't know why but a simpler example would tease that bug out.
I tried to withMsg'ify the loadfile section, and change the allknn type sig to take a History, but I ran into an escaped scope. Maybe the context stuff only works if you have exactly 1 use floating around.


          added withMsg to History and created exec/hlearn-allknn-bench.hs

c4c7188

Owner

mikeizbicki commented Jun 17, 2015

Thanks for doing this! I've just glanced through, and the big picture ideas look good.

It'll probably be a few days before I can look at this in more detail though. If I haven't gotten back to you by next week, ping me again.

tonyday567 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet