Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: plugin-manager should have way to get info about available plugins #47

Open
djzager opened this issue Nov 5, 2021 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@djzager
Copy link
Contributor

djzager commented Nov 5, 2021

Feature Request

The plugin-manager should provide an info subcommand that gives users more information about the specified plugin.

Description

Currently, the plugin-manager subcommand supports listing of the available plugins, for example:

$ crane plugin-manager list --params
Listing from the repo default
+-------------+--------------------+----------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|    NAME     |  SHORTDESCRIPTION  |        DESCRIPTION         | AVAILABLEVERSIONS |                                                                                   OPTIONALFIELDS                                                                                   |
+-------------+--------------------+----------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| pvc         | pvc                | this is pvc                | 0.0.1             |                                                                                                                                                                                    |
+-------------+--------------------+----------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| hc-whiteout | hc-whiteout plugin | this is hc-whiteout plugin | 0.0.1             |                                                                                                                                                                                    |
+-------------+--------------------+----------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| openshift   | openshift          | this is openshift          | 1.0.7             | - FlagName: StripDefaultPullSecrets                                                                                                                                                |
|             |                    |                            |                   |   Help: Whether to strip Pod and BuildConfig default pull secrets (beginning with builder/default/deployer-dockercfg-) that aren't replaced by the map param PullSecretReplacement |
|             |                    |                            |                   |   Example: true                                                                                                                                                                    |
|             |                    |                            |                   | - FlagName: PullSecretReplacement                                                                                                                                                  |
|             |                    |                            |                   |   Help: Map of pull secrets to replace in Pods and BuildConfigs while transforming in format secret1=destsecret1,secret2=destsecret2[...]                                          |
|             |                    |                            |                   |   Example: default-dockercfg-h4n7g=default-dockercfg-12345,builder-dockercfg-abcde=builder-dockercfg-12345                                                                         |
|             |                    |                            |                   | - FlagName: RegistryReplacement                                                                                                                                                    |
|             |                    |                            |                   |   Help: Map of image registry paths to swap on transform, in the format original-registry1=target-registry1,original-registry2=target-registry2...                                 |
|             |                    |                            |                   |   Example: docker-registry.default.svc:5000=image-registry.openshift-image-registry.svc:5000,docker.io/foo=quay.io/bar                                                             |
+-------------+--------------------+----------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

However, this doesn't give the end user much insight into what the plugin does, how it does it, or the when/why the end user would install and use it.

And instead of using table to consume this information, output similar to something like following makes more sense:

Name:                  OpenshiftPlugin
ShortDescription:    <short-description>
Description:            <description>
Version:                   <version>
OptionalFields:        <optional-fields>

Solution

Introduce an info subcommand that provides long form explanation of a specified user plugin.

Alternative Solutions

  • Populating the SHORTDESCRIPTION and DESCRIPTION with an actual description 😎 might lessen the need for a new info command.
  • Change the output from table to similar to something that is mentioned above.
@JaydipGabani
Copy link
Contributor

Updating SHORTDESCRIPTION and DESCRIPTION with appropriate information is in the list, so this might be updated in a while

@djzager djzager added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 18, 2022
@eriknelson
Copy link
Contributor

/kind enhancement
/priority low
/triage accepted

@openshift-ci openshift-ci bot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jun 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2022

@eriknelson: The label(s) kind/enhancement, priority/low cannot be applied, because the repository doesn't have them.

In response to this:

/kind enhancement
/priority low
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

This issue synced with: https://issues.redhat.com/browse/MTRHO-65

@eriknelson
Copy link
Contributor

/priority minor

@openshift-ci openshift-ci bot added the priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Jun 24, 2022
@eriknelson eriknelson removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 24, 2022
@eriknelson
Copy link
Contributor

/kind enhancement

@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2022

@eriknelson: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eriknelson
Copy link
Contributor

/kind feature

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants