Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grow 1299 #67

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Grow 1299 #67

merged 5 commits into from
Apr 12, 2024

Conversation

samad-yar-khan
Copy link
Contributor

Why do we need this ?

  • Need robust tests for cfr aggregate api

Proposed Changes

  • Add factory for ChangeFailureRateMetrics
  • Add factory for Deployment
  • Add tests for incident_service.get_change_failure_rate_metrics
  • Update tests for incident_service.get_deployment_incidents_map

amoghjalan
amoghjalan approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@amoghjalan amoghjalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samad-yar-khan samad-yar-khan merged commit d0ebc23 into main Apr 12, 2024
1 check passed
@samad-yar-khan samad-yar-khan deleted the GROW-1299 branch April 12, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoghjalan amoghjalan amoghjalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samad-yar-khan @amoghjalan