Skip to content

Commit

Permalink
Update ProviderETLHandler names to be specific to model.
Browse files Browse the repository at this point in the history
  • Loading branch information
amoghjalan committed Apr 9, 2024
1 parent da7c060 commit 115b4ee
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions apiserver/dora/service/code/sync/etl_code_factory.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
from dora.service.code.sync.etl_github_handler import get_github_etl_handler
from dora.service.code.sync.etl_provider_handler import ProviderETLHandler
from dora.service.code.sync.etl_provider_handler import CodeProviderETLHandler
from dora.store.models.code import CodeProvider


class CodeETLFactory:
def __init__(self, org_id: str):
self.org_id = org_id

def __call__(self, provider: str) -> ProviderETLHandler:
def __call__(self, provider: str) -> CodeProviderETLHandler:
if provider == CodeProvider.GITHUB.value:
return get_github_etl_handler(self.org_id)
4 changes: 2 additions & 2 deletions apiserver/dora/service/code/sync/etl_github_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

from dora.exapi.github import GithubApiService
from dora.service.code.sync.etl_code_analytics import CodeETLAnalyticsService
from dora.service.code.sync.etl_provider_handler import ProviderETLHandler
from dora.service.code.sync.etl_provider_handler import CodeProviderETLHandler
from dora.service.code.sync.revert_prs_github_sync import (
RevertPRsGitHubSyncHandler,
get_revert_prs_github_sync_handler,
Expand All @@ -34,7 +34,7 @@
PR_PROCESSING_CHUNK_SIZE = 100


class GithubETLHandler(ProviderETLHandler):
class GithubETLHandler(CodeProviderETLHandler):
def __init__(
self,
org_id: str,
Expand Down
4 changes: 2 additions & 2 deletions apiserver/dora/service/code/sync/etl_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import pytz

from dora.service.code.integration import get_code_integration_service
from dora.service.code.sync.etl_code_factory import ProviderETLHandler, CodeETLFactory
from dora.service.code.sync.etl_code_factory import CodeProviderETLHandler, CodeETLFactory
from dora.store.models.code import OrgRepo, BookmarkType, Bookmark, PullRequest
from dora.store.repos.code import CodeRepoService
from dora.utils.log import LOG
Expand All @@ -14,7 +14,7 @@ class CodeETLHandler:
def __init__(
self,
code_repo_service: CodeRepoService,
etl_service: ProviderETLHandler,
etl_service: CodeProviderETLHandler,
):
self.code_repo_service = code_repo_service
self.etl_service = etl_service
Expand Down
2 changes: 1 addition & 1 deletion apiserver/dora/service/code/sync/etl_provider_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
)


class ProviderETLHandler(ABC):
class CodeProviderETLHandler(ABC):
@abstractmethod
def check_pat_validity(self) -> bool:
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import pytz

from dora.exapi.github import GithubApiService
from dora.service.workflows.sync.etl_provider_handler import ProviderETLHandler
from dora.service.workflows.sync.etl_provider_handler import WorkflowProviderETLHandler
from dora.store.models import UserIdentityProvider
from dora.store.models.code import (
RepoWorkflowProviders,
Expand All @@ -21,7 +21,7 @@
WORKFLOW_PROCESSING_CHUNK_SIZE = 100


class GithubActionsETLHandler(ProviderETLHandler):
class GithubActionsETLHandler(WorkflowProviderETLHandler):
def __init__(self, org_id: str, github_api_service: GithubApiService):
self.org_id = org_id
self._api: GithubApiService = github_api_service
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
)


class ProviderETLHandler(ABC):
class WorkflowProviderETLHandler(ABC):
@abstractmethod
def check_pat_validity(self) -> bool:
"""
Expand Down

0 comments on commit 115b4ee

Please sign in to comment.