Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Thales.SafeNetAuthenticationClient version 10.9.3283.0 #173818

Merged

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Sep 16, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Sep 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 16, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

No errors to post.

(Automated response - build 895.)

@R-Adrian
Copy link

R-Adrian commented Sep 17, 2024

question: does the slash direction matter for syntax validation in RelativeFilePath?
i see that this PR uses forward slashes while most other PRs i've seen use back slashes

e.g.
RelativeFilePath: Msi/x64/SafeNetAuthenticationClient-x64-10.9.msi
vs
RelativeFilePath: Msi\x64\SafeNetAuthenticationClient-x64-10.9.msi

update: looking at the ZIP format APPNOTE.TXT specification it looks like forward slashes is actually the correct format.
quote:

   4.4.17 file name: (Variable)

       4.4.17.1 The name of the file, with optional relative path.
       The path stored MUST NOT contain a drive or
       device letter, or a leading slash.  All slashes
       MUST be forward slashes '/' as opposed to
       backwards slashes '\' for compatibility with Amiga
       and UNIX file systems etc.  If input came from standard
       input, there is no file name field.  

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 17, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Sep 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Sep 17, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application labels Sep 17, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Sep 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 17, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335141
2024-09-17 03:19:00.701 [CLI ] Unable to locate nested installer at: C:\Users\VALIDA1\AppData\Local\Temp\WinGet\Thales.SafeNetAuthenticationClient.10.9.3283.0\extracted\Msi/x64/SafeNetAuthenticationClient-x64-10.9.msi
2024-09-17 03:18:52.553 [CLI ] Unable to locate nested installer at: C:\Users\VALIDA
1\AppData\Local\Temp\WinGet\Thales.SafeNetAuthenticationClient.10.9.3283.0\extracted\Msi/x32/SafeNetAuthenticationClient-x32-10.9.msi

Automated error analysis suggests -1978335141 may mean Unable to locate nested installer. Does the RelativeFilePath have the previous version number in it?

(Automated response - build 895.)

@stephengillie
Copy link
Collaborator

question: does the slash direction matter for syntax validation in RelativeFilePath? i see that this PR uses forward slashes while most other PRs i've seen use back slashes

e.g. RelativeFilePath: Msi/x64/SafeNetAuthenticationClient-x64-10.9.msi vs RelativeFilePath: Msi\x64\SafeNetAuthenticationClient-x64-10.9.msi

update: looking at the ZIP format APPNOTE.TXT specification it looks like forward slashes is actually the correct format. quote:

   4.4.17 file name: (Variable)

       4.4.17.1 The name of the file, with optional relative path.
       The path stored MUST NOT contain a drive or
       device letter, or a leading slash.  All slashes
       MUST be forward slashes '/' as opposed to
       backwards slashes '\' for compatibility with Amiga
       and UNIX file systems etc.  If input came from standard
       input, there is no file name field.  

This is something that we're not currently checking, but probably should be. We usually don't notice it, I believe, because the string is likely used on a Windows system after replacing the slashes for backslashes,

Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Dragon1573,

It appears that a folder is missing from the RelativeFilePath:
image

- Fix errors in `RelativeFilePath`.

Co-authored-by: Stephen Gillie <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application Changes-Requested Changes Requested Moderator-Approved One of the Moderators has reviewed and approved this PR labels Sep 18, 2024
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Sep 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 18, 2024
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Domain Needs-Author-Feedback This needs a response from the author. labels Sep 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit d735769 into microsoft:master Sep 18, 2024
8 checks passed
@Dragon1573 Dragon1573 deleted the issues/173741 branch September 18, 2024 16:08
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
5 participants