Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Package] Added MartiCliment.UniGetUI.Pre-Release version 3.1.0-alpha1 #173817

Conversation

vikingnope
Copy link
Contributor

@vikingnope vikingnope commented Sep 16, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


#173379

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Sep 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 16, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Sep 16, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Sep 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 16, 2024
@vikingnope
Copy link
Contributor Author

@stephengillie, This package had problems with installing correctly even though it does install correctly, this was the first of UniGetUI, it can be published

#156394

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 16, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

No errors to post.

(Automated response - build 895.)

@stephengillie
Copy link
Collaborator

Verify:
image
Watching this install reminded me why this package doesn't pass the pipelines - because for some reason, the package manager mis-detects the dependency installer as the main installer, and so it returns and gives exit codes once Microsoft.EdgeWebView2Runtime is installed, but before this package has completed. Or a similar situation.

@stephengillie
Copy link
Collaborator

stephengillie commented Sep 16, 2024

Edit: Forgot to swap labels before running the automation.

@wingetbot
Copy link
Collaborator

Commenter does not have sufficient privileges for PR 173817

@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Installation-Error Error installing application Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 14a0b4d into microsoft:master Sep 16, 2024
1 of 2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 16, 2024
@vikingnope vikingnope deleted the move-unigetui-prerelease-3.1.0-alpha1 branch September 16, 2024 21:41
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants