Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Version: Guru3D.RTSS version 7.3.5 #142094

Merged
merged 2 commits into from
Mar 6, 2024
Merged

New Version: Guru3D.RTSS version 7.3.5 #142094

merged 2 commits into from
Mar 6, 2024

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented Mar 4, 2024 •
edited
Loading

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@og-mrk
Copy link
Contributor Author

og-mrk commented Mar 4, 2024

Hello @stephengillie,

May I ask why Linking PR to Issue isn't working? Thought it was a simple Keyword Usage in PR Description and that's it... maybe there's something I'm missing?

Thanks in advance 😄

@og-mrk
Copy link
Contributor Author

og-mrk commented Mar 4, 2024

Oh I see.. turns out that a Colon : was messing with the PR to Issue Linking Keyword.
Fixed it, my bad for pinging you stephengillie

@og-mrk og-mrk mentioned this pull request Mar 4, 2024
Closed
6 tasks
@og-mrk
Copy link
Contributor Author

og-mrk commented Mar 4, 2024

Looks like the Validation of URL seems to suggest that this URL (ftp.nluug.nl) requires Manual Review, link log line, and a link to warning

@wingetbot wingetbot mentioned this pull request Mar 4, 2024
Closed
1 task
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Mar 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 4, 2024
@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Domain

@wingetbot
Copy link
Collaborator

Commenter does not have sufficient privileges for PR 142094

@og-mrk
Copy link
Contributor Author

og-mrk commented Mar 5, 2024

Interesting respond by @wingetbot ...
Is there anything I can do to help with validation URL problem @stephengillie ?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 5, 2024
@og-mrk
Update Guru3D.RTSS.installer.yaml
3bd76f5 
chnaged 'ElevationRequirement' from 'elevationRequired' to 'elevatesSelf'.
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Mar 5, 2024
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. New-Manifest labels Mar 5, 2024
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Mar 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 5, 2024
@stephengillie
Copy link
Collaborator

Interesting respond by @wingetbot ... Is there anything I can do to help with validation URL problem @stephengillie ?

I'm testing some small changes in moderation for the team to bugfix. This is another bug we've just found.

@denelon
Copy link
Contributor

denelon commented Mar 5, 2024

@wingetbot waivers Add Validation-Domain

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain Needs-Author-Feedback This needs a response from the author. labels Mar 5, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 6, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 6, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 6, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 6, 2024
@denelon denelon merged commit 9f93a95 into microsoft:master Mar 6, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@og-mrk og-mrk deleted the update-manifest/Guru3D.RTSS-version7.3.5 branch March 8, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Domain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: Guru3D.RTSS version 7.3.5
4 participants
@og-mrk @wingetbot @stephengillie @denelon