Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TeamViewer.TeamViewer.Host.installer.yaml #142063

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Update TeamViewer.TeamViewer.Host.installer.yaml #142063

merged 1 commit into from
Mar 5, 2024

Conversation

Exorcism0666
Copy link
Contributor

@Exorcism0666 Exorcism0666 commented Mar 4, 2024 •
edited by microsoft-github-policy-service bot
Loading

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Possible-Duplicate Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 4, 2024
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: 6b2256559e36802c4c74e7068a6e110babcc82e8f2d30f788c4c7c7f6e461079
    • manifests\t\TeamViewer\TeamViewer\Host\15.51.5
    • manifests\t\TeamViewer\TeamViewer\15.51.5
  • InstallerSha256: 1b231347ebce60f9d176b85c2089ea98a404f1adf59a4e31c1cc7e2b1aa647e6
    • manifests\t\TeamViewer\TeamViewer\15.51.5

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 4, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 4, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 4, 2024
@Exorcism0666
Copy link
Contributor Author

@stephengillie

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 4, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 5, 2024
@Exorcism0666
Copy link
Contributor Author

For moderators

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

Warning

With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

Important

Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 5, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 5, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 5, 2024
@og-mrk
Copy link
Contributor

og-mrk commented Mar 5, 2024

Hello @stephengillie ,

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: 6b2256559e36802c4c74e7068a6e110babcc82e8f2d30f788c4c7c7f6e461079
    • manifests\t\TeamViewer\TeamViewer\Host\15.51.5
    • manifests\t\TeamViewer\TeamViewer\15.51.5
  • InstallerSha256: 1b231347ebce60f9d176b85c2089ea98a404f1adf59a4e31c1cc7e2b1aa647e6
    • manifests\t\TeamViewer\TeamViewer\15.51.5

This PR is modifing the same Installer Manifest File (filepath: manifests/t/TeamViewer/TeamViewer/Host/15.51.5/TeamViewer.TeamViewer.Host.installer.yaml) as the one being reported by @wingetbot , meaning it's a False Positive.

And the PR looks good to me. The validation tests have passed successfully, meaning the HASH value for added Installer(s) do match the ones being provided, as well as the URL is from a reputable source.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 5, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 5, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Mar 5, 2024
@denelon denelon merged commit 354b2ae into microsoft:master Mar 5, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Possible-Duplicate Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: TeamViewer Host x64 version
5 participants
@Exorcism0666 @wingetbot @og-mrk @stephengillie @denelon