Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: CrystalDewWorld.CrystalDiskMark version 8.0.5 #140949

Conversation

Exorcism0666
Copy link
Contributor

@Exorcism0666 Exorcism0666 commented Feb 26, 2024

Pull request has been created with komac v2.1.0 🍏

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Exorcism0666
Copy link
Contributor Author

For moderators

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

Warning

With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

Important

Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください!

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Unapproved-URL labels Feb 26, 2024
@wingetbot
Copy link
Collaborator

=== manifests\c\CrystalDewWorld\CrystalDiskMark\8.0.5 ===
Missing Properties value based on version 8.0.4.c:
MinimumOSVersion

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Unapproved-URL

@stephengillie
Copy link
Collaborator

Hi @Exorcism0666,

This PR's version number 8.0.5 has 3 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 8.0.4.c, which has 4 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)

(Automated response - build 821)

@stephengillie
Copy link
Collaborator

Hi @Exorcism0666,

This manifest removes Apps and Features entries that are present in previous PR versions. Should these entries also be added to this version?

(Automated response - build 821.)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Version-Parameter-Mismatch This manifest's package version has a different number of parameters than the newest in repo. labels Feb 26, 2024
@Exorcism0666
Copy link
Contributor Author

Hi @Exorcism0666,

This manifest removes Apps and Features entries that are present in previous PR versions. Should these entries also be added to this version?

(Automated response - build 821.)

No!

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 26, 2024
@stephengillie
Copy link
Collaborator

Apps and features entries are supposed to be all-or-none. So if the other versions have it, then it should be included here also. (I need to update my messages.)

@MagicAndre1981
Copy link

Hi @Exorcism0666,
This manifest removes Apps and Features entries that are present in previous PR versions. Should these entries also be added to this version?
(Automated response - build 821.)

No!

@Exorcism0666

the old manifest for 8.0.4c has those entries:

  AppsAndFeaturesEntries:
  - DisplayName: CrystalDiskMark 8.0.4c
    DisplayVersion: 8.0.4c

I think this is what @stephengillie requests. Old manifest also has MinimumOSVersion: 10.0.0.0 entry which is now also missing.

@MagicAndre1981
Copy link

@Exorcism0666 do you still work on this PR?

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. New-Manifest labels Mar 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Metadata-Consistency Version-Parameter-Mismatch This manifest's package version has a different number of parameters than the newest in repo. labels Mar 17, 2024
@Exorcism0666
Copy link
Contributor Author

@Exorcism0666 do you still work on this PR?

Sorry for my inactivity, about "MinimumOS", it's useless here.

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Unapproved-URL labels Mar 17, 2024
@wingetbot
Copy link
Collaborator

=== manifests\c\CrystalDewWorld\CrystalDiskMark\8.0.5 ===
Missing Properties value based on version 8.0.4.c:
MinimumOSVersion

@MagicAndre1981
Copy link

@Exorcism0666 do you still work on this PR?

Sorry for my inactivity, about "MinimumOS", it's useless here.

ok, the bot still wants it as it was declared in the past. @Exorcism0666

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Unapproved-URL

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Unapproved-URL labels Mar 18, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 18, 2024
@wingetbot
Copy link
Collaborator

=== manifests\c\CrystalDewWorld\CrystalDiskMark\8.0.5 ===
Missing Properties value based on version 8.0.4.c:
MinimumOSVersion

@stephengillie
Copy link
Collaborator

Hi @Exorcism0666,

This PR's version number 8.0.5 has 3 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 8.0.4.c, which has 4 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)

(Automated response - build 870)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Version-Parameter-Mismatch This manifest's package version has a different number of parameters than the newest in repo. labels Mar 18, 2024
@MagicAndre1981
Copy link

Hi @Exorcism0666,

This PR's version number 8.0.5 has 3 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 8.0.4.c, which has 4 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)

Do you mean this? It is version 8.0.5:

image

last manifest has a mistake, the version is 8.0.4c, NOT 8.0.4.c

image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 20, 2024
@stephengillie stephengillie merged commit 7d33376 into microsoft:master Mar 20, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Mar 20, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Exorcism0666 Exorcism0666 deleted the CrystalDewWorld.CrystalDiskMark-8.0.5-4D7E3A7E240E4EB0A339436A87CDC6DE branch March 20, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manifest-Metadata-Consistency Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed Version-Parameter-Mismatch This manifest's package version has a different number of parameters than the newest in repo. Waived-Validation-Unapproved-URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: Update CrystalDewWorld.CrystalDiskMark to 8.0.5
4 participants