Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xterm and integrate new scroll bars #221500

Merged
merged 10 commits into from
Jul 11, 2024
Merged

Update xterm and integrate new scroll bars #221500

merged 10 commits into from
Jul 11, 2024

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 11, 2024

Fixes #211199
Fixes #216521
See xtermjs/xterm.js#5096

The change is fairly big due to the way that the viewport is dealt with is quite different and vscode had a bunch of customizations to the old way to get it to bottom align, fill horizontal space, etc.

Wins:

Changes:

  • This removes the 2px padding on the very bottom of the terminal in order for the scroll bar to extend all the way to the bottom of the panel. This was a workaround to help display underscores in the terminal under certain fonts when using the DOM renderer. Let's fix issues as they come as this was a hack that degraded the default (webgl) UX.

Before:

image

After:

image

@Tyriar Tyriar added this to the July 2024 milestone Jul 11, 2024
@Tyriar Tyriar self-assigned this Jul 11, 2024
@Tyriar Tyriar marked this pull request as ready for review July 11, 2024 18:58
meganrogge
meganrogge previously approved these changes Jul 11, 2024
meganrogge
meganrogge previously approved these changes Jul 11, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Jul 11, 2024

Integration test failed again, weird. Surprised this PR could impact that one

Looking into this exact thing later in #221399 anyway
@Tyriar Tyriar enabled auto-merge July 11, 2024 23:11
@Tyriar Tyriar merged commit 6d7dc00 into main Jul 11, 2024
6 checks passed
@Tyriar Tyriar deleted the tyriar/scrollbar branch July 11, 2024 23:30
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants