Skip to content

Commit

Permalink
Add needs to CI coverage check (#24421)
Browse files Browse the repository at this point in the history
Fixes #23052 

Added "needs" to the Coverage check, so it only runs if all the previous
tests mentioned pass.


![image](https://github.com/user-attachments/assets/9ba79542-5327-457a-b7cd-2e26d0f3ce7e)

We could also set `fail-fast` to `true` if we want to stop the workflow
when any tests fail.

Please let me know if it needs any modifications.
  • Loading branch information
brokoli777 authored Nov 12, 2024
1 parent 006dd23 commit 4bc7ff7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@ jobs:
name: Coverage
# The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded.
runs-on: ${{ matrix.os }}
needs: [lint, check-types, python-tests, tests, native-tests]
strategy:
fail-fast: false
matrix:
Expand Down

0 comments on commit 4bc7ff7

Please sign in to comment.