Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor push image to be a wizard, show ACR create pick #4146

Merged
merged 8 commits into from
Nov 7, 2023
Merged

Refactor push image to be a wizard, show ACR create pick #4146

merged 8 commits into from
Nov 7, 2023

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Oct 31, 2023 •
edited
Loading

Fixes #4086

Scenarios to test:

  • Non-fully-qualified image
    • To Docker Hub
    • To ACR
      • Create ACR
    • No connected registry
    • Prompt for registry disabled
  • Fully-qualified image
    • To Docker Hub
    • To ACR
    • No connected registry
    • Prompt for registry disabled

@bwateratmsft bwateratmsft requested a review from a team as a code owner October 31, 2023 14:44
karolz-ms
karolz-ms approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first time I am looking at the new registry stuff, so take my approval with a grain of salt ☺️ ... but LGTIM

@bwateratmsft bwateratmsft merged commit 5372c56 into main Nov 7, 2023
2 checks passed
@bwateratmsft bwateratmsft deleted the bmw/pushImageAsWizard branch November 7, 2023 16:22
@microsoft microsoft locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karolz-ms karolz-ms karolz-ms approved these changes

@danegsta danegsta Awaiting requested review from danegsta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is no "+ Create new registry..." in "Select registry" option
2 participants
@bwateratmsft @karolz-ms