Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the showing of stale View Properties data #785

Closed
wants to merge 8 commits into from

Conversation

MicroFish91
Copy link
Contributor

@MicroFish91 MicroFish91 commented Nov 1, 2024

Fixes #330

After updates and refreshes, the View Properties data is often stale. It seems that although the view itself is showing the correct and updated data, the tree item that is passed into the View Properties command is often a stale one.

I looked but could not find what would be causing this to happen, however, there are some easy ways for me to help combat this in the ACA extension until we figure out a more robust solution. To combat this locally, I have made a global resource cache that all relevant tree items would have reference to. The idea is that if a stale item is passed to the view properties command, the item now has a link to a global reference from which it can pull the latest data, independent from the state of the current item. The cache is refreshed naturally with the latest data whenever we issue refresh commands because the setting is done whenever the tree items are first constructed / refreshed. This should theoretically always keep it in sync with the latest view.

@MicroFish91 MicroFish91 marked this pull request as ready for review December 3, 2024 00:33
@MicroFish91 MicroFish91 requested a review from a team as a code owner December 3, 2024 00:33
@MicroFish91
Copy link
Contributor Author

Closing in favor of an alternative custom solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The replicas value doesn't auto refresh in the "xxx_Scaling.json" file after editing scaling range
1 participant