Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Edit Container Image... command #778

Merged
merged 20 commits into from
Dec 2, 2024
Merged

Conversation

MicroFish91
Copy link
Contributor

@MicroFish91 MicroFish91 commented Oct 23, 2024

Basically the same as the Update Container... command, but skips the prompt to update environment variables.

This is a more specific command to only update the image child only.

image

Update: Changed to Edit Container Image...

@MicroFish91 MicroFish91 marked this pull request as ready for review October 23, 2024 19:16
@MicroFish91 MicroFish91 requested a review from a team as a code owner October 23, 2024 19:16
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to Alex's comment in your Update Container... PR, I think that this could benefit from some verbiage changes.

Specifically, I feel like Update Container Image... could be more easily conflated with actually updating the container app or people may think that they can only make minor edits to an existing image.

Deploy Container Image... or Deploy new Container Image... gives me the impression that I am overwriting whatever the current image is.

Not blocking for this, just noting that we should have a conversation about it.

src/utils/pickItem/pickImage.ts Outdated Show resolved Hide resolved
Base automatically changed from mwf/presidential-pink to main November 27, 2024 06:32
@MicroFish91 MicroFish91 changed the title Add Update Container Image... command Add Edit Container Image... command Nov 27, 2024
@MicroFish91
Copy link
Contributor Author

MicroFish91 commented Nov 27, 2024

Similar to Alex's comment in your Update Container... PR, I think that this could benefit from some verbiage changes.

Specifically, I feel like Update Container Image... could be more easily conflated with actually updating the container app or people may think that they can only make minor edits to an existing image.

Changed to Edit Container Image... based on recent discussions

@MicroFish91 MicroFish91 changed the title Add Edit Container Image... command Add an Edit Container Image... command Nov 27, 2024
@MicroFish91 MicroFish91 merged commit 5aa0a42 into main Dec 2, 2024
2 checks passed
@MicroFish91 MicroFish91 deleted the mwf/symbolic-tomato branch December 2, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants