Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled using bootstrap.sh from any msys2 bash env. #41779

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enabled using bootstrap.sh from any msys2 bash env. #41779

wants to merge 3 commits into from
+3 −3

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Oct 25, 2024

When using the default/root msys2 environment MSYS, uname -s reports the OS kernel name as being "MSYS_NT".

Also checked other msys2 environments by setting MSYSTEM env. var. to CLANG64, UCRT64 - in addition to MSYS and MINGW64:

  • kernel name is MINGW64_NT when MSYSTEM=MINGW64
  • kernel name is MINGW32_NT when MSYSTEM=MINGW32
  • kernel name is MINGW64_NT when MSYSTEM=CLANG64
  • kernel name is MINGW64_NT when MSYSTEM=UCRT64
  • kernel name is MSYS_NT when MSYSTEM=MSYS

@stemann
Enabled using bootstrap.sh from any msys2 bash env.
530834c 
When using the default/root msys2 environment MSYS, `uname -s` reports the OS kernel name as being "MSYS_NT".
dg0yt
dg0yt reviewed Oct 25, 2024
View reviewed changes
scripts/bootstrap.sh Outdated Show resolved Hide resolved
WangWeiLin-MV
WangWeiLin-MV approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test pass on MSYS2 - UCRT64 and MSYS2 - MSYS2 with:

sh bootstrap-vcpkg.sh

@WangWeiLin-MV WangWeiLin-MV added info:reviewed Pull Request changes follow basic guidelines category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stemann @dg0yt @WangWeiLin-MV