-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xmlsec] Update to version 1.3.6 #41737
Open
metsma
wants to merge
8
commits into
microsoft:master
Choose a base branch
from
metsma:xmlsec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+32
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Metsma <[email protected]>
…config Signed-off-by: Raul Metsma <[email protected]>
Signed-off-by: Raul Metsma <[email protected]>
dg0yt
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The LIBXML_STATIC
definitions should be removed. This is handled by the libxml2 port and has not effect in vcpkg.
FrankXie05
added
the
category:port-update
The issue is with a library, which is requesting update new revision
label
Oct 24, 2024
metsma
force-pushed
the
xmlsec
branch
5 times, most recently
from
October 24, 2024 06:14
336245a
to
0aba878
Compare
dg0yt
suggested changes
Oct 24, 2024
Signed-off-by: Raul Metsma <[email protected]>
Signed-off-by: Raul Metsma <[email protected]>
Signed-off-by: Raul Metsma <[email protected]>
FrankXie05
previously approved these changes
Oct 25, 2024
FrankXie05
added
the
requires:all-feature-testing
vcpkg install port[all features supported by that port] needs to be demonstrated to function
label
Oct 25, 2024
dg0yt
reviewed
Oct 25, 2024
Signed-off-by: Raul Metsma <[email protected]>
Signed-off-by: Raul Metsma <[email protected]>
FrankXie05
approved these changes
Oct 28, 2024
FrankXie05
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:all-feature-testing
vcpkg install port[all features supported by that port] needs to be demonstrated to function
labels
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-update
The issue is with a library, which is requesting update new revision
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --all
and committing the result.Signed-off-by: Raul Metsma [email protected]