Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scotch] update to v7.0.5 #41712

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Conversation

Mengna-Li
Copy link
Contributor

Update to v7.0.5.
No feature need to test.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Mengna-Li Mengna-Li added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Oct 22, 2024
@Mengna-Li Mengna-Li marked this pull request as ready for review October 23, 2024 01:19
FrankXie05
FrankXie05 previously approved these changes Oct 23, 2024
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Oct 23, 2024
@data-queue
Copy link
Contributor

Can you explain why we run add_library(scotcherr ...) twice in the patch?

@data-queue data-queue marked this pull request as draft October 23, 2024 05:57
@Mengna-Li
Copy link
Contributor Author

Can you explain why we run add_library(scotcherr ...) twice in the patch?

These two are different.

add_library(scotcherr library_error.c)
add_library(scotcherrexit library_error_exit.c)

In fact, I didn't change the content of the patch, I just applied the previous patch to the latest release.

@Mengna-Li Mengna-Li marked this pull request as ready for review October 23, 2024 06:08
@data-queue
Copy link
Contributor

In the final patch, we run add_library(scotcherr library_error.c) twice

@dg0yt
Copy link
Contributor

dg0yt commented Oct 23, 2024

The patch seems to need a thorough review.

@Mengna-Li Mengna-Li marked this pull request as draft October 23, 2024 06:59
@Mengna-Li Mengna-Li marked this pull request as ready for review October 24, 2024 07:37
@data-queue data-queue merged commit a18a047 into microsoft:master Oct 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants