[qtquick3d] devendor meshoptimizer

[m-kuhn]

@Neumann-A does this need to be upstreamed to be acceptable?

[FrankXie05]

This patch is too large. 🤨 Is this patch necessary now?

[m-kuhn]

I could reduce the patch and not remove the library (or use file(REMOVE_RECURSE src/3rdparty/meshoptimizer) instead)

[FrankXie05]

We can download it through vcpkg_download_distfile.
eg:

vcpkg/ports/alsa/portfile.cmake

Line 14 in c8582b4

vcpkg_download_distfile(ALSA_VERSION_SCRIPT_PATCH

[m-kuhn]

let me reduce it, I think it's more transparent and maintainable

[Neumann-A]

xatlas should probably also be devendored then?

[m-kuhn]

probably, I only did the one that was causing pain for me and xatlas would require a new port afaics.

[Neumann-A]

@Neumann-A does this need to be upstreamed to be acceptable?

Why are you asking me. Having it upstream would be better for future updates. You probably need to move the find_package logic into a configure.cmake file which has a feature depending on INPUT_<something>='system'. qtmultimedia has a few of those if i remember correctly.

[m-kuhn]

@Neumann-A does this need to be upstreamed to be acceptable?

Why are you asking me.

For this kind of valuable feedback:

Having it upstream would be better for future updates. You probably need to move the find_package logic into a configure.cmake file which has a feature depending on INPUT_<something>='system'. qtmultimedia has a few of those if i remember correctly.

[m-kuhn]

Upstream PR here https://codereview.qt-project.org/c/qt/qtquick3d/+/599071/1