-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qtquick3d] devendor meshoptimizer #41708
base: master
Are you sure you want to change the base?
Conversation
This patch is too large. 🤨 Is this patch necessary now? |
I could reduce the patch and not remove the library (or use |
We can download it through vcpkg/ports/alsa/portfile.cmake Line 14 in c8582b4
|
let me reduce it, I think it's more transparent and maintainable |
DEFINES | ||
QT_BUILD_QUICK3DUTILS_LIB | ||
INCLUDE_DIRECTORIES | ||
../3rdparty/xatlas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xatlas should probably also be devendored then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably, I only did the one that was causing pain for me and xatlas would require a new port afaics.
Why are you asking me. Having it upstream would be better for future updates. You probably need to move the find_package logic into a configure.cmake file which has a feature depending on |
For this kind of valuable feedback:
|
Upstream PR here https://codereview.qt-project.org/c/qt/qtquick3d/+/599071/1 |
@Neumann-A does this need to be upstreamed to be acceptable?