Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mimalloc] Fix build error on x64-android #41694

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jimwang118
Copy link
Contributor

/home/vzhli17/jim/vcpkg/buildtrees/mimalloc/src/v2.1.7-d58a1dd7b9/src/arena.c:798:3: error: no matching function for call to 'atomic_store_explicit'
  mi_atomic_store_release(&segment->thread_id, 0);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Refer to upstream PR 694 for modification.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Compile test pass with following triplets:


x64-windows
x64-android

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 21, 2024
@jimwang118
Copy link
Contributor Author

An issue 950 was raised upstream for tracking.

@jimwang118 jimwang118 marked this pull request as ready for review October 22, 2024 02:05
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Oct 25, 2024
@data-queue
Copy link
Contributor

Can you submit an upstream PR?

@data-queue data-queue marked this pull request as draft October 26, 2024 09:30
@jimwang118
Copy link
Contributor Author

Can you submit an upstream PR?

Submitted PR 954 upstream.

@jimwang118 jimwang118 marked this pull request as ready for review October 28, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants