Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][vulkan-utility-libraries] Passing remove form fail list #41689

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Oct 21, 2024

Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=108312&view=results

PASSING, REMOVE FROM FAIL LIST: vulkan-utility-libraries:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: vulkan-utility-libraries:x64-android
PASSING, REMOVE FROM FAIL LIST: vulkan-utility-libraries:arm64-android

Added vulkan-utility-libraries=fail to ci.baseline.txt by #35742. This issue is now fixed by #40107.

Add port vulkan-validationlayers to the ci file. Because the code determines that Android NDK is greater than 25.

/home/vzhli17/jim/vcpkg/buildtrees/vulkan-validationlayers/src/-1.3.296.0-ba9cf3639b.clean/layers/vk_layer_config.cpp:182:5: error: static_assert failed due to requirement 'android_api >= target_android_api' "Vulkan-ValidationLayers is not supported on Android 25 and below"
    static_assert(android_api >= target_android_api, "Vulkan-ValidationLayers is not supported on Android 25 and below");
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@jimwang118 jimwang118 added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Oct 21, 2024
@jimwang118 jimwang118 marked this pull request as ready for review October 23, 2024 01:52
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Oct 23, 2024
@data-queue data-queue merged commit 339af2c into microsoft:master Oct 23, 2024
16 checks passed
Comment on lines +1161 to +1163
vulkan-validationlayers:arm64-android=fail
vulkan-validationlayers:x64-android=fail
vulkan-validationlayers:arm-neon-android=fail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ascending sorting also for triplets next time, so that others don't have to resolve merge conflicts. CI runs for baseline changes are expensive. Another one for #40339.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we will sort them in ascending order from now on.

@jimwang118 jimwang118 deleted the fix-vulkan-utility-libraries branch October 23, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants