Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed-containers] add new port #41677

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Conversation

jiayuehua
Copy link
Contributor

@jiayuehua jiayuehua commented Oct 20, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 21, 2024
@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows (header files found):

fixed-containers provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(fixed_containers CONFIG REQUIRED)
  target_link_libraries(main PRIVATE fixed_containers::fixed_containers)

MonicaLiu0311
MonicaLiu0311 previously approved these changes Oct 21, 2024
@MonicaLiu0311 MonicaLiu0311 added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Oct 21, 2024
@jiayuehua
Copy link
Contributor Author

done.

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Oct 22, 2024
@@ -0,0 +1,35 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we need this patch?

@jiayuehua
Copy link
Contributor Author

need to add magic_enum dependedency, so add it to Fixed-containersConfig.cmake.in file. After cmake build complete, need to install config file, so that user can use through find_package .

@data-queue data-queue merged commit 612279c into microsoft:master Oct 23, 2024
16 checks passed
@jiayuehua jiayuehua deleted the fixed-containers branch October 23, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants