-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[casadi] first step (no dependencies) #41649
Conversation
@microsoft-github-policy-service agree company="yacoda" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be more practical to format the portfile with spaces, not tabs. (Tabs are subject to settings. GH PR review looks strange.)
I see a lot of find modules. I would expect a similar set of dependencies in the manifest.
Maybe put the PR in draft state as long as it is not ready for review. |
@dg0yt Thanks for your review, I assumed you would not start a review while CI still runs.. CasADi works with a plugin system. I'll think about adding the namespace upstream. |
@dg0yt The CI checking seems to stall; x64_linux is compiling whole of llvm, and windows builds queue until timeout. |
CI has a real problem. |
Oh I see, thanks for helping out this vcpkg noob. |
Usage test pass with following triplet:
|
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.